OCPBUGS-63347: Define Default timeouts and apply their usage accross to avoid flakes #535
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@camilamacedo86: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
camilamacedo86
force-pushed
the
increase-timeouts
branch
from
113dcae to
8b03b85
Compare
| err := k8sClient.Get(ctx, client.ObjectKey{Name: name}, crb) | ||
| g.Expect(err).ToNot(HaveOccurred(), fmt.Sprintf("failed to get ClusterRoleBinding %q: %v", name, err)) | ||
| }).WithTimeout(10*time.Second).WithPolling(1*time.Second).Should(Succeed(), "ClusterRoleBinding %q did not become visible within timeout", name) | ||
| }).WithTimeout(2*time.Minute).WithPolling(3*time.Second).Should(Succeed(), "ClusterRoleBinding %q did not become visible within timeout", name) |
There was a problem hiding this comment.
This couldn't be DefaultPolling at least?
There was a problem hiding this comment.
3*time.Second => DefaultPolling
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
…oss to avoid flakes
camilamacedo86
force-pushed
the
increase-timeouts
branch
from
8b03b85 to
604f94b
Compare
|
/lgtm |
|
/retest-required |
camilamacedo86
changed the title
openshift-ci-robot
added
the
jira/valid-bug
|
@camilamacedo86: This pull request references Jira Issue OCPBUGS-63347, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@camilamacedo86: This pull request references Jira Issue OCPBUGS-63347, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
verified
|
@bandrade: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 08ecdc2
into
openshift:main
|
@camilamacedo86: Jira Issue OCPBUGS-63347: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-63347 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5 participants
We need to use a generous timeout for these tests.
Some environments take a long time to start, and short timeouts can cause false failures.
These failures send bad signals to Sippy and, worse, can block other developers — since these tests run against every PR in the org.