OCPBUGS-63347: Fix flake for single/own ns tests by ensuring uniquess and waiting for k8s cleanups #536
Conversation
camilamacedo86
force-pushed
the
fix-flake-single-own
branch
from
7a9ec18 to
6469981
Compare
camilamacedo86
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@camilamacedo86: This pull request references Jira Issue OCPBUGS-63347, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.21-e2e-azure-ovn-runc-techpreview 10 |
|
@camilamacedo86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0da7b520-af29-11f0-8292-1b57e8686926-0 |
|
@camilamacedo86: This pull request references Jira Issue OCPBUGS-63347, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
camilamacedo86
force-pushed
the
fix-flake-single-own
branch
from
6469981 to
8d8cad4
Compare
camilamacedo86
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
fix-flake-single-own
branch
from
8d8cad4 to
759a83c
Compare
|
@camilamacedo86: This pull request references Jira Issue OCPBUGS-63347, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
added
the
needs-rebase
camilamacedo86
force-pushed
the
fix-flake-single-own
branch
from
759a83c to
c0228bd
Compare
openshift-merge-robot
removed
the
needs-rebase
camilamacedo86
changed the title
camilamacedo86
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.21-e2e-azure-ovn-runc-techpreview 10 |
|
@camilamacedo86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/105b5b70-af81-11f0-81e6-138c28a7a8e0-0 |
…uess and waiting for k8s cleanups Co-Author: kuiwang@redhat.com
camilamacedo86
force-pushed
the
fix-flake-single-own
branch
from
c0228bd to
714977c
Compare
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6-techpreview 5 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/514a1b20-afc3-11f0-92cb-20c526e8b5bc-0 |
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.21-e2e-azure-ovn-runc-techpreview 10 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/58745d70-afc3-11f0-8547-d673022f6ab0-0 |
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-serial-ovn-ipv6-techpreview-1of2 5 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5f07b6f0-afc3-11f0-8844-398a621512d6-0 |
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-serial-ovn-ipv6-techpreview-2of2 5 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/67e80db0-afc3-11f0-9101-de353a4966c9-0 |
|
@camilamacedo86: This pull request references Jira Issue OCPBUGS-63347, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (bandrade@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
| } | ||
|
|
||
| // Ensure unique names per scenario | ||
| crdSuffix := rand.String(4) |
There was a problem hiding this comment.
Nit: I realize this is the original name of the variable, but it's used for more than just the CRD. So perhaps unique (used in other place), might be better.
| if crdName != "" { | ||
| crd := &apiextensionsv1.CustomResourceDefinition{} | ||
| if err := k8sClient.Get(context.Background(), client.ObjectKey{Name: crdName}, crd); err == nil { | ||
| By(fmt.Sprintf("cleanup: deleting CRD %s", crdName)) | ||
| _ = k8sClient.Delete(context.Background(), crd) | ||
| } | ||
| } |
There was a problem hiding this comment.
We're waiting on the namepsace to be deleted, do we need to wait on the CRD to be deleted too? I see that the tests are passing, so this might just be something we need to keep an eye on.
There was a problem hiding this comment.
We call helpers.EnsureCleanupClusterExtension(context.Background(), ceName, namespace) at the cleanup. But since it is only be called after all we can use it here as well
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold cancel PR is merged now: #532 |
| "{{ TEST-CONTROLLER }}": singleownImage, | ||
| "{{ CRD-SUFFIX }}": crdSuffix, // Unique CRD suffix per scenario | ||
| "{{ PACKAGE-NAME }}": packageName, | ||
| "webhook-operator-webhooktest-admin-role": fmt.Sprintf("webhook-operator-webhooktest-admin-role-%s", crdSuffix), |
There was a problem hiding this comment.
FYI
"webhook-operator-webhooktest-admin-role": fmt.Sprintf("webhook-operator-webhooktest-admin-role-%s", crdSuffix),
"webhook-operator-webhooktest-editor-role": fmt.Sprintf("webhook-operator-webhooktest-editor-role-%s", crdSuffix),
"webhook-operator-webhooktest-viewer-role": fmt.Sprintf("webhook-operator-webhooktest-viewer-role-%s", crdSuffix),
"webhook-operator-metrics-reader": fmt.Sprintf("webhook-operator-metrics-reader-%s", crdSuffix),although I do not think it is necessary (actually it is not used), it will not impact the case execution.
|
/verified by @kuiwang02 |
openshift-ci-robot
added
the
verified
|
@kuiwang02: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@camilamacedo86: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 4522e35
into
openshift:main
|
@camilamacedo86: Jira Issue Verification Checks: Jira Issue OCPBUGS-63347 Jira Issue OCPBUGS-63347 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.21.0-0.nightly-2025-10-25-183621 |
5 participants
This change ensures each test scenario has unique resources, preventing
name clashes even when cleanup takes longer than expected. Also, we are improving the cleanups and waits to avoid flakes.
Local tests
** Aggregations **
periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-serial-ovn-ipv6-techpreview-1of2
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5f07b6f0-afc3-11f0-8844-398a621512d6-0
🟢
'Passed 5 times, failed 0 times, skipped 0 times: we require at least 6 attemptsperiodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-serial-ovn-ipv6-techpreview-2of2
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/67e80db0-afc3-11f0-9101-de353a4966c9-0
🟢
'Passed 5 times, failed 0 times, skipped 0 times: we require at least 6 attemptsperiodic-ci-openshift-release-master-nightly-4.21-e2e-azure-ovn-runc-techpreview
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/58745d70-afc3-11f0-8547-d673022f6ab0-0
🟢 But the test passed, the failures in the job are unrelated
periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6-techpreview
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/514a1b20-afc3-11f0-92cb-20c526e8b5bc-0
🟢
'Passed 5 times, failed 0 times, skipped 0 times: we require at least 6 attemptsperiodic-ci-openshift-release-master-nightly-4.21-e2e-azure-ovn-runc-techpreview
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/105b5b70-af81-11f0-81e6-138c28a7a8e0-0
🟢 But the test passed, the failures in the job are unrelated
Co-Author: @kuiwang02