OCPQE-31083: Update OwnSingle template to use inline.watchNamespace for QE cases #541

kuiwang02 · 2025-11-04T00:19:59Z

Fix test failures for OwnNamespace/SingleNamespace modes

Update clusterextension-withselectorlabel-OwnSingle.yaml template to use spec.config.inline.watchNamespace instead of deprecated annotations.

Fixes: PolarionID:81664, PolarionID:81696

Changes

Replace metadata.annotations["olm.operatorframework.io/watch-namespace"]
With spec.config.inline.watchNamespace

Impact

✅ Case 81664 (OwnNamespace mode) - PASSED
✅ Case 81696 (SingleNamespace mode) - PASSED

Product code now requires watchNamespace configuration via the config.inline API for bundles supporting OwnNamespace and SingleNamespace InstallModes.

Testing

./bin/olmv1-tests-ext run-test "[sig-olmv1][Jira:OLM] clusterextension PolarionID:81696-[Skipped:Disconnected]preflight check on permission on single ns mode"
[INFO] [env] Using kubeconfig: /Users/kuiwang/work/bin/jb/kubeconf/kubeconfig
[INFO] [env] Cluster environment initialized (OpenShift: true)
I1103 18:30:01.981447 15470 test_context.go:566] The --provider flag is not set. Continuing as if --provider=skeleton had been used.
Running Suite:  - /Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-operator-controller/openshift/tests-extension
==============================================================================================================================================
Random Seed: 1762165799 - will randomize all specs

Will run 1 of 1 specs
------------------------------
[sig-olmv1][Jira:OLM] clusterextension PolarionID:81696-[Skipped:Disconnected]preflight check on permission on single ns mode [NonHyperShiftHOST]
/Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-operator-controller/openshift/tests-extension/test/qe/specs/olmv1_ce.go:679
  STEP: Creating a kubernetes client @ 11/03/25 18:30:01.983
...
{
  "name": "[sig-olmv1][Jira:OLM] clusterextension PolarionID:81696-[Skipped:Disconnected]preflight check on permission on single ns mode",
  "lifecycle": "blocking",
  "duration": 124393,
  "startTime": "2025-11-03 10:30:01.981901 UTC",
  "endTime": "2025-11-03 10:32:06.375493 UTC",
  "result": "passed"
...
./bin/olmv1-tests-ext run-test "[sig-olmv1][Jira:OLM] clusterextension PolarionID:81664-[Skipped:Disconnected]preflight check on permission on own ns mode"
[INFO] [env] Using kubeconfig: /Users/kuiwang/work/bin/jb/kubeconf/kubeconfig
[INFO] [env] Cluster environment initialized (OpenShift: true)
I1103 18:20:22.992672 10510 test_context.go:566] The --provider flag is not set. Continuing as if --provider=skeleton had been used.
Running Suite:  - /Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-operator-controller/openshift/tests-extension
==============================================================================================================================================
Random Seed: 1762165220 - will randomize all specs

Will run 1 of 1 specs
------------------------------
[sig-olmv1][Jira:OLM] clusterextension PolarionID:81664-[Skipped:Disconnected]preflight check on permission on own ns mode [NonHyperShiftHOST]
/Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-operator-controller/openshift/tests-extension/test/qe/specs/olmv1_ce.go:570
  STEP: Creating a kubernetes client @ 11/03/25 18:20:22.999
...
  "name": "[sig-olmv1][Jira:OLM] clusterextension PolarionID:81664-[Skipped:Disconnected]preflight check on permission on own ns mode",
  "lifecycle": "informing",
  "duration": 114133,
  "startTime": "2025-11-03 10:20:22.993496 UTC",
  "endTime": "2025-11-03 10:22:17.126713 UTC",
  "result": "passed",

Assisted-by: Claude Code

…e.watchNamespace

openshift-ci-robot · 2025-11-04T00:20:03Z

@kuiwang02: This pull request references OCPQE-31083 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Fix test failures for OwnNamespace/SingleNamespace modes

Update clusterextension-withselectorlabel-OwnSingle.yaml template to use spec.config.inline.watchNamespace instead of deprecated annotations.

Fixes: PolarionID:81664, PolarionID:81696

Changes

Replace metadata.annotations["olm.operatorframework.io/watch-namespace"]
With spec.config.inline.watchNamespace

Impact

✅ Case 81664 (OwnNamespace mode) - PASSED
✅ Case 81696 (SingleNamespace mode) - PASSED

Product code now requires watchNamespace configuration via the config.inline API for bundles supporting OwnNamespace and SingleNamespace InstallModes.

Testing

./bin/olmv1-tests-ext run-test "[sig-olmv1][Jira:OLM] clusterextension PolarionID:81696-[Skipped:Disconnected]preflight check on permission on single ns mode"
[INFO] [env] Using kubeconfig: /Users/kuiwang/work/bin/jb/kubeconf/kubeconfig
[INFO] [env] Cluster environment initialized (OpenShift: true)
I1103 18:30:01.981447 15470 test_context.go:566] The --provider flag is not set. Continuing as if --provider=skeleton had been used.
Running Suite:  - /Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-operator-controller/openshift/tests-extension
==============================================================================================================================================
Random Seed: 1762165799 - will randomize all specs

Will run 1 of 1 specs
------------------------------
[sig-olmv1][Jira:OLM] clusterextension PolarionID:81696-[Skipped:Disconnected]preflight check on permission on single ns mode [NonHyperShiftHOST]
/Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-operator-controller/openshift/tests-extension/test/qe/specs/olmv1_ce.go:679
  STEP: Creating a kubernetes client @ 11/03/25 18:30:01.983
...
{
  "name": "[sig-olmv1][Jira:OLM] clusterextension PolarionID:81696-[Skipped:Disconnected]preflight check on permission on single ns mode",
  "lifecycle": "blocking",
  "duration": 124393,
  "startTime": "2025-11-03 10:30:01.981901 UTC",
  "endTime": "2025-11-03 10:32:06.375493 UTC",
  "result": "passed"
...
./bin/olmv1-tests-ext run-test "[sig-olmv1][Jira:OLM] clusterextension PolarionID:81664-[Skipped:Disconnected]preflight check on permission on own ns mode"
[INFO] [env] Using kubeconfig: /Users/kuiwang/work/bin/jb/kubeconf/kubeconfig
[INFO] [env] Cluster environment initialized (OpenShift: true)
I1103 18:20:22.992672 10510 test_context.go:566] The --provider flag is not set. Continuing as if --provider=skeleton had been used.
Running Suite:  - /Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-operator-controller/openshift/tests-extension
==============================================================================================================================================
Random Seed: 1762165220 - will randomize all specs

Will run 1 of 1 specs
------------------------------
[sig-olmv1][Jira:OLM] clusterextension PolarionID:81664-[Skipped:Disconnected]preflight check on permission on own ns mode [NonHyperShiftHOST]
/Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-operator-controller/openshift/tests-extension/test/qe/specs/olmv1_ce.go:570
  STEP: Creating a kubernetes client @ 11/03/25 18:20:22.999
...
  "name": "[sig-olmv1][Jira:OLM] clusterextension PolarionID:81664-[Skipped:Disconnected]preflight check on permission on own ns mode",
  "lifecycle": "informing",
  "duration": 114133,
  "startTime": "2025-11-03 10:20:22.993496 UTC",
  "endTime": "2025-11-03 10:22:17.126713 UTC",
  "result": "passed",

Assisted-by: Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kuiwang02 · 2025-11-04T01:11:00Z

/close

for more checking. if necessary, reopen it.

openshift-ci · 2025-11-04T01:11:16Z

@kuiwang02: Closed this PR.

In response to this:

/close

for more checking. if necessary, reopen it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kuiwang02 · 2025-11-04T23:42:53Z

/reopen

openshift-ci · 2025-11-04T23:43:03Z

@kuiwang02: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-11-04T23:43:05Z

@kuiwang02: This pull request references OCPQE-31083 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Fix test failures for OwnNamespace/SingleNamespace modes

Update clusterextension-withselectorlabel-OwnSingle.yaml template to use spec.config.inline.watchNamespace instead of deprecated annotations.

Fixes: PolarionID:81664, PolarionID:81696

Changes

Replace metadata.annotations["olm.operatorframework.io/watch-namespace"]
With spec.config.inline.watchNamespace

Impact

✅ Case 81664 (OwnNamespace mode) - PASSED
✅ Case 81696 (SingleNamespace mode) - PASSED

Product code now requires watchNamespace configuration via the config.inline API for bundles supporting OwnNamespace and SingleNamespace InstallModes.

Testing

./bin/olmv1-tests-ext run-test "[sig-olmv1][Jira:OLM] clusterextension PolarionID:81696-[Skipped:Disconnected]preflight check on permission on single ns mode"
[INFO] [env] Using kubeconfig: /Users/kuiwang/work/bin/jb/kubeconf/kubeconfig
[INFO] [env] Cluster environment initialized (OpenShift: true)
I1103 18:30:01.981447 15470 test_context.go:566] The --provider flag is not set. Continuing as if --provider=skeleton had been used.
Running Suite:  - /Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-operator-controller/openshift/tests-extension
==============================================================================================================================================
Random Seed: 1762165799 - will randomize all specs

Will run 1 of 1 specs
------------------------------
[sig-olmv1][Jira:OLM] clusterextension PolarionID:81696-[Skipped:Disconnected]preflight check on permission on single ns mode [NonHyperShiftHOST]
/Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-operator-controller/openshift/tests-extension/test/qe/specs/olmv1_ce.go:679
  STEP: Creating a kubernetes client @ 11/03/25 18:30:01.983
...
{
  "name": "[sig-olmv1][Jira:OLM] clusterextension PolarionID:81696-[Skipped:Disconnected]preflight check on permission on single ns mode",
  "lifecycle": "blocking",
  "duration": 124393,
  "startTime": "2025-11-03 10:30:01.981901 UTC",
  "endTime": "2025-11-03 10:32:06.375493 UTC",
  "result": "passed"
...
./bin/olmv1-tests-ext run-test "[sig-olmv1][Jira:OLM] clusterextension PolarionID:81664-[Skipped:Disconnected]preflight check on permission on own ns mode"
[INFO] [env] Using kubeconfig: /Users/kuiwang/work/bin/jb/kubeconf/kubeconfig
[INFO] [env] Cluster environment initialized (OpenShift: true)
I1103 18:20:22.992672 10510 test_context.go:566] The --provider flag is not set. Continuing as if --provider=skeleton had been used.
Running Suite:  - /Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-operator-controller/openshift/tests-extension
==============================================================================================================================================
Random Seed: 1762165220 - will randomize all specs

Will run 1 of 1 specs
------------------------------
[sig-olmv1][Jira:OLM] clusterextension PolarionID:81664-[Skipped:Disconnected]preflight check on permission on own ns mode [NonHyperShiftHOST]
/Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-operator-controller/openshift/tests-extension/test/qe/specs/olmv1_ce.go:570
  STEP: Creating a kubernetes client @ 11/03/25 18:20:22.999
...
  "name": "[sig-olmv1][Jira:OLM] clusterextension PolarionID:81664-[Skipped:Disconnected]preflight check on permission on own ns mode",
  "lifecycle": "informing",
  "duration": 114133,
  "startTime": "2025-11-03 10:20:22.993496 UTC",
  "endTime": "2025-11-03 10:22:17.126713 UTC",
  "result": "passed",

Assisted-by: Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

camilamacedo86 · 2025-11-05T00:34:52Z

openshift/tests-extension/.openshift-tests-extension/openshift_payload_olmv1.json

    },
    "source": "openshift:payload:olmv1",
-    "lifecycle": "informing",
+    "lifecycle": "blocking",


Is it producing signal to Sippy?
Could we move all tests that will become a blocking to be centralised?

In this case, can we move any QE shaped test to : https://github.com/openshift/operator-framework-operator-controller/blob/main/openshift/tests-extension/test/

Also, are those scenarios that are not covered yet?
It would be great we ensure that we have not many tests covering the same.

Otherwise, it might start be hard for we keep things maintained.

it is for QE case. it is different with case migrated from origin.

camilamacedo86 · 2025-11-05T00:35:10Z

openshift/tests-extension/cmd/main.go

+			// QE case becomes better so that we could try it
+			// if !spec.Labels.Has("ReleaseGate") && spec.Lifecycle == "blocking" {
+			// 	spec.Lifecycle = "informing"
+			// }


Could we not merge code commented?

I will like to keep it because we will monitor it. I will remove it after we approve the QE design in the future.

kuiwang02 · 2025-11-05T01:26:33Z

/verified by @kuiwang02

openshift-ci-robot · 2025-11-05T01:26:45Z

@kuiwang02: This PR has been marked as verified by @kuiwang02.

In response to this:

/verified by @kuiwang02

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-11-05T02:41:28Z

@kuiwang02: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jianzhangbjz · 2025-11-05T03:27:12Z

/approve
/lgtm

openshift-ci · 2025-11-05T03:27:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, kuiwang02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [jianzhangbjz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

UPSTREAM: <carry>: Update OwnSingle template to use spec.config.inlin…

53e7d9a

…e.watchNamespace

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2025

openshift-ci bot requested review from camilamacedo86 and grokspawn November 4, 2025 00:20

openshift-ci bot closed this Nov 4, 2025

openshift-ci bot reopened this Nov 4, 2025

camilamacedo86 reviewed Nov 5, 2025

View reviewed changes

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 5, 2025

openshift-ci bot assigned jianzhangbjz Nov 5, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025

openshift-merge-bot bot merged commit 92dcb88 into openshift:main Nov 5, 2025
13 checks passed

OCPQE-31083: Update OwnSingle template to use inline.watchNamespace for QE cases #541

OCPQE-31083: Update OwnSingle template to use inline.watchNamespace for QE cases #541

Conversation

kuiwang02 commented Nov 4, 2025

Fix test failures for OwnNamespace/SingleNamespace modes

Changes

Impact

Testing

Uh oh!

openshift-ci-robot commented Nov 4, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix test failures for OwnNamespace/SingleNamespace modes

Changes

Impact

Testing

Uh oh!

kuiwang02 commented Nov 4, 2025

Uh oh!

openshift-ci bot commented Nov 4, 2025

Uh oh!

kuiwang02 commented Nov 4, 2025

Uh oh!

openshift-ci bot commented Nov 4, 2025

Uh oh!

openshift-ci-robot commented Nov 4, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix test failures for OwnNamespace/SingleNamespace modes

Changes

Impact

Testing

Uh oh!

camilamacedo86 Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kuiwang02 Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kuiwang02 Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

kuiwang02 commented Nov 5, 2025

Uh oh!

openshift-ci-robot commented Nov 5, 2025

Uh oh!

openshift-ci bot commented Nov 5, 2025

Uh oh!

jianzhangbjz commented Nov 5, 2025

Uh oh!

openshift-ci bot commented Nov 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openshift-ci-robot commented Nov 4, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 4, 2025 •

edited by openshift-ci bot

Loading

camilamacedo86 Nov 5, 2025 •

edited

Loading

camilamacedo86 Nov 5, 2025 •

edited

Loading