OCPBUGS-65825: Upgrade sigs.k8s.io/crdify from sigs.k8s.io/crdify v0.4.1-0.20250825182107-69e65223aee0 to v0.5.0 to ensure that all bug fixes are properly ported

[camilamacedo86]

Although we’ve addressed a significant number of CRDUpgrade safety issues, we have not yet upgraded to the latest release version used in 4.21 to ensure that we incorporate all bug fixes.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign oceanc80 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@camilamacedo86: An error was encountered adding this pull request to the external tracker bugs for bug OCPBUGS-60958 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.

failed to add remote link: failed to add link: title - The length of the 'Link Text' field cannot exceed 255 characters.: request failed. Please analyze the request body for more details. Status code: 400:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

Ports all bug fixes for CRD upgrade safety preflight checks from upstream/release-4.21. All mandatory bug fixes are addressed.

Related Issues:

• https://issues.redhat.com/browse/OCPBUGS-60958
• https://issues.redhat.com/browse/OCPBUGS-60693
• https://issues.redhat.com/browse/OCPBUGS-60962
• https://issues.redhat.com/browse/OCPBUGS-60963
• https://issues.redhat.com/browse/OCPBUGS-64643
• https://issues.redhat.com/browse/OCPBUGS-64726
• https://issues.redhat.com/browse/OCPBUGS-59518

What Changed

Bug Fixes Ported ✅

1. crdify v0.5.0 - Present in go.mod

• Includes ratcheting fixes
• Includes enum addition handling
• Includes items schema processing fixes

2. Unhandled changes message formatting (OCPBUGS-59518)

• conciseUnhandledMessage() function
• extractUnhandledDetails() function
• Used in sameVersionErrors() and servedVersionErrors()

3. Enum configuration (additionPolicy: Allow)

• Enum validation config with AdditionPolicyAllow

4. Description field handling

• Description validation set to EnforcementPolicyNone

Verification

All bug fixes are present and verified:

# crdify version
grep crdify go.mod
# ✅ sigs.k8s.io/crdify v0.5.0

# Bug fix functions
grep -r "conciseUnhandledMessage\|extractUnhandledDetails" internal/operator-controller/rukpak/preflights/crdupgradesafety/
# ✅ Both functions present

# Enum config
grep -r "additionPolicy.*Allow" internal/operator-controller/rukpak/preflights/crdupgradesafety/
# ✅ Present

Note on Interface

The current branch uses *release.Release interface while upstream/release-4.21 uses []client.Object. This is an architectural difference, not a bug fix requirement. All bug fixes work correctly with the current interface.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[camilamacedo86]

/jira refresh

[openshift-ci-robot]

@camilamacedo86: An error was encountered adding this pull request to the external tracker bugs for bug OCPBUGS-60958 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.

failed to add remote link: failed to add link: title - The length of the 'Link Text' field cannot exceed 255 characters.: request failed. Please analyze the request body for more details. Status code: 400:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@camilamacedo86: This pull request references Jira Issue OCPBUGS-60958, which is invalid:

• expected the bug to target the "4.20.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-60958 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Ports all bug fixes for CRD upgrade safety preflight checks from upstream/release-4.21. All mandatory bug fixes are addressed.

Related Issues:

• https://issues.redhat.com/browse/OCPBUGS-60958
• https://issues.redhat.com/browse/OCPBUGS-60693
• https://issues.redhat.com/browse/OCPBUGS-60962
• https://issues.redhat.com/browse/OCPBUGS-60963
• https://issues.redhat.com/browse/OCPBUGS-64643
• https://issues.redhat.com/browse/OCPBUGS-64726
• https://issues.redhat.com/browse/OCPBUGS-59518

What Changed

Bug Fixes Ported ✅

1. crdify v0.5.0 - Present in go.mod

• Includes ratcheting fixes
• Includes enum addition handling
• Includes items schema processing fixes

2. Unhandled changes message formatting (OCPBUGS-59518)

• conciseUnhandledMessage() function
• extractUnhandledDetails() function
• Used in sameVersionErrors() and servedVersionErrors()

3. Enum configuration (additionPolicy: Allow)

• Enum validation config with AdditionPolicyAllow

4. Description field handling

• Description validation set to EnforcementPolicyNone

Verification

All bug fixes are present and verified:

# crdify version
grep crdify go.mod
# ✅ sigs.k8s.io/crdify v0.5.0

# Bug fix functions
grep -r "conciseUnhandledMessage\|extractUnhandledDetails" internal/operator-controller/rukpak/preflights/crdupgradesafety/
# ✅ Both functions present

# Enum config
grep -r "additionPolicy.*Allow" internal/operator-controller/rukpak/preflights/crdupgradesafety/
# ✅ Present

Note on Interface

The current branch uses *release.Release interface while upstream/release-4.21 uses []client.Object. This is an architectural difference, not a bug fix requirement. All bug fixes work correctly with the current interface.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@camilamacedo86: This pull request references Jira Issue OCPBUGS-60958, which is invalid:

• expected the bug to target only the "4.20.z" version, but multiple target versions were set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-60958 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Ports all bug fixes for CRD upgrade safety preflight checks from upstream/release-4.21. All mandatory bug fixes are addressed.

Related Issues:

• https://issues.redhat.com/browse/OCPBUGS-60693
• https://issues.redhat.com/browse/OCPBUGS-60962
• https://issues.redhat.com/browse/OCPBUGS-60963
• https://issues.redhat.com/browse/OCPBUGS-64643
• https://issues.redhat.com/browse/OCPBUGS-64726
• https://issues.redhat.com/browse/OCPBUGS-59518

What Changed

Bug Fixes Ported ✅

1. crdify v0.5.0 - Present in go.mod

• Includes ratcheting fixes
• Includes enum addition handling
• Includes items schema processing fixes

2. Unhandled changes message formatting (OCPBUGS-59518)

• conciseUnhandledMessage() function
• extractUnhandledDetails() function
• Used in sameVersionErrors() and servedVersionErrors()

3. Enum configuration (additionPolicy: Allow)

• Enum validation config with AdditionPolicyAllow

4. Description field handling

• Description validation set to EnforcementPolicyNone

Verification

All bug fixes are present and verified:

# crdify version
grep crdify go.mod
# ✅ sigs.k8s.io/crdify v0.5.0

# Bug fix functions
grep -r "conciseUnhandledMessage\|extractUnhandledDetails" internal/operator-controller/rukpak/preflights/crdupgradesafety/
# ✅ Both functions present

# Enum config
grep -r "additionPolicy.*Allow" internal/operator-controller/rukpak/preflights/crdupgradesafety/
# ✅ Present

Note on Interface

The current branch uses *release.Release interface while upstream/release-4.21 uses []client.Object. This is an architectural difference, not a bug fix requirement. All bug fixes work correctly with the current interface.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@camilamacedo86: This pull request references Jira Issue OCPBUGS-60693, which is invalid:

• expected the bug to target the "4.20.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-60693 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Ports all bug fixes for CRD upgrade safety preflight checks from upstream/release-4.21. All mandatory bug fixes are addressed.

Related Issues:

• https://issues.redhat.com/browse/OCPBUGS-60693
• https://issues.redhat.com/browse/OCPBUGS-60962
• https://issues.redhat.com/browse/OCPBUGS-60963
• https://issues.redhat.com/browse/OCPBUGS-64643
• https://issues.redhat.com/browse/OCPBUGS-64726
• https://issues.redhat.com/browse/OCPBUGS-59518

What Changed

Bug Fixes Ported ✅

1. crdify v0.5.0 - Present in go.mod

• Includes ratcheting fixes
• Includes enum addition handling
• Includes items schema processing fixes

2. Unhandled changes message formatting (OCPBUGS-59518)

• conciseUnhandledMessage() function
• extractUnhandledDetails() function
• Used in sameVersionErrors() and servedVersionErrors()

3. Enum configuration (additionPolicy: Allow)

• Enum validation config with AdditionPolicyAllow

4. Description field handling

• Description validation set to EnforcementPolicyNone

Verification

All bug fixes are present and verified:

# crdify version
grep crdify go.mod
# ✅ sigs.k8s.io/crdify v0.5.0

# Bug fix functions
grep -r "conciseUnhandledMessage\|extractUnhandledDetails" internal/operator-controller/rukpak/preflights/crdupgradesafety/
# ✅ Both functions present

# Enum config
grep -r "additionPolicy.*Allow" internal/operator-controller/rukpak/preflights/crdupgradesafety/
# ✅ Present

Note on Interface

The current branch uses *release.Release interface while upstream/release-4.21 uses []client.Object. This is an architectural difference, not a bug fix requirement. All bug fixes work correctly with the current interface.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@camilamacedo86: This pull request explicitly references no jira issue.

In response to this:

Ports all bug fixes for CRD upgrade safety preflight checks from upstream/release-4.21. All mandatory bug fixes are addressed.

Related Issues:

• https://issues.redhat.com/browse/OCPBUGS-60693
• https://issues.redhat.com/browse/OCPBUGS-60962
• https://issues.redhat.com/browse/OCPBUGS-60963
• https://issues.redhat.com/browse/OCPBUGS-64643
• https://issues.redhat.com/browse/OCPBUGS-64726

What Changed

Bug Fixes Ported ✅

1. crdify v0.5.0 - Present in go.mod

• Includes ratcheting fixes
• Includes enum addition handling
• Includes items schema processing fixes

2. Unhandled changes message formatting (OCPBUGS-59518)

• conciseUnhandledMessage() function
• extractUnhandledDetails() function
• Used in sameVersionErrors() and servedVersionErrors()

3. Enum configuration (additionPolicy: Allow)

• Enum validation config with AdditionPolicyAllow

4. Description field handling

• Description validation set to EnforcementPolicyNone

Verification

All bug fixes are present and verified:

# crdify version
grep crdify go.mod
# ✅ sigs.k8s.io/crdify v0.5.0

# Bug fix functions
grep -r "conciseUnhandledMessage\|extractUnhandledDetails" internal/operator-controller/rukpak/preflights/crdupgradesafety/
# ✅ Both functions present

# Enum config
grep -r "additionPolicy.*Allow" internal/operator-controller/rukpak/preflights/crdupgradesafety/
# ✅ Present

Note on Interface

The current branch uses *release.Release interface while upstream/release-4.21 uses []client.Object. This is an architectural difference, not a bug fix requirement. All bug fixes work correctly with the current interface.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[camilamacedo86]

/retest-required

[openshift-ci-robot]

@camilamacedo86: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Ports all bug fixes for CRD upgrade changes to ensure that we can address all possible bugs done in 4.21
We have a ton of bugs related to this feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@camilamacedo86: This pull request references Jira Issue OCPBUGS-65825, which is invalid:

• expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.z" instead
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-65825 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Ports all bug fixes for CRD upgrade changes to ensure that we can address all possible bugs done in 4.21
We have a ton of bugs related to this feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@camilamacedo86: This pull request references Jira Issue OCPBUGS-65825, which is invalid:

• expected Jira Issue OCPBUGS-65825 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Although we’ve addressed a significant number of CRDUpgrade safety issues, we have not yet upgraded to the latest release version used in 4.21 to ensure that we incorporate all bug fixes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[camilamacedo86]

/jira refresh

[openshift-ci-robot]

@camilamacedo86: This pull request references Jira Issue OCPBUGS-65825, which is invalid:

• expected dependent Jira Issue OCPBUGS-65827 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Obsolete) instead
• expected dependent Jira Issue OCPBUGS-65827 to target a version in 4.21.0, but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[camilamacedo86]

/jira refresh

[openshift-ci-robot]

@camilamacedo86: This pull request references Jira Issue OCPBUGS-65825, which is invalid:

• expected dependent Jira Issue OCPBUGS-65827 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Obsolete) instead
• expected dependent Jira Issue OCPBUGS-65827 to target a version in 4.21.0, but it targets "4.21" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[camilamacedo86]

/jira refresh

[openshift-ci-robot]

@camilamacedo86: This pull request references Jira Issue OCPBUGS-65825, which is invalid:

• expected dependent Jira Issue OCPBUGS-65827 to target a version in 4.21.0, but it targets "4.21" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[camilamacedo86]

/jira refresh

[openshift-ci-robot]

@camilamacedo86: This pull request references Jira Issue OCPBUGS-65825, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.z) matches configured target version for branch (4.20.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-65827 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-65827 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
• bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[camilamacedo86]

Not required
the commits are identical

sigs.k8s.io/crdify v0.4.1-0.20250825182107-69e65223aee0

sigs.k8s.io/crdify v0.5.0

We have no changes in the files

[openshift-ci-robot]

@camilamacedo86: This pull request references Jira Issue OCPBUGS-65825. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Although we’ve addressed a significant number of CRDUpgrade safety issues, we have not yet upgraded to the latest release version used in 4.21 to ensure that we incorporate all bug fixes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.