OPRUN-4228: Add boxcutter tests

[camilamacedo86]

No description provided.

[coderabbitai]

Walkthrough

Added five new OLMv1 Boxcutter runtime test entries to the test manifest file and implemented corresponding test cases in Go that validate cluster extension lifecycle operations including installation, status updates, resource labeling, cleanup, and reinstallation. All tests are gated by the OCPFeatureGate:NewOLMBoxCutterRuntime feature flag.

Changes

Cohort / File(s)	Summary
OLMv1 Boxcutter Runtime Tests openshift/tests-extension/.openshift-tests-extension/openshift_payload_olmv1.json	Added five new test manifest entries gated by OCPFeatureGate:NewOLMBoxCutterRuntime, marked as blocking lifecycle tests for Boxcutter runtime cluster extension operations: installation, active revision reporting, resource labeling, cleanup, and reinstallation.
OLMv1 Boxcutter Runtime Test Implementation openshift/tests-extension/test/olmv1-boxcutter.go	New Ginkgo test suite implementing five test cases validating OLMv1 Boxcutter runtime functionality: ClusterExtension installation and availability, active revision status reporting, OLM ownership label verification on managed resources, deletion and cleanup behavior, and post-deletion reinstallation capability.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@camilamacedo86: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@camilamacedo86: This pull request references OPRUN-4228 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

🧹 Nitpick comments (1)

openshift/tests-extension/test/olmv1-boxcutter.go (1)

163-192: Consider adding DeferCleanup for the first extension as a safety net.

If this test fails between creating the first ClusterExtension (line 168) and calling firstCleanup() (line 176), orphaned resources will remain until the next test run cleans them via EnsureCleanupClusterExtension. While this eventually self-heals, adding a DeferCleanup call immediately after creation provides more robust cleanup:

♻️ Suggested improvement

 	By("applying the ClusterExtension resource for the first time")
 	firstName, firstCleanup := helpers.CreateClusterExtension(opName, "", nsName, unique, helpers.WithCatalogNameSelector(ccName))
+	DeferCleanup(firstCleanup)
 
 	By("waiting for the first installation to complete")

This ensures cleanup happens even if the test fails early. The explicit firstCleanup() call on line 176 will still work (cleanup functions typically ignore "not found" errors).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@openshift/tests-extension/test/olmv1-boxcutter.go` around lines 163 - 192,
After creating the first ClusterExtension with helpers.CreateClusterExtension
(returning firstName, firstCleanup), immediately register the cleanup with
DeferCleanup(firstCleanup) to guarantee resource cleanup if the test fails
before the explicit firstCleanup() call; keep the existing explicit
firstCleanup() later (it will be a no-op if already cleaned), and reference
firstName/firstCleanup/CreateClusterExtension/DeferCleanup when making this
change.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@openshift/tests-extension/test/olmv1-boxcutter.go`:
- Around line 163-192: After creating the first ClusterExtension with
helpers.CreateClusterExtension (returning firstName, firstCleanup), immediately
register the cleanup with DeferCleanup(firstCleanup) to guarantee resource
cleanup if the test fails before the explicit firstCleanup() call; keep the
existing explicit firstCleanup() later (it will be a no-op if already cleaned),
and reference firstName/firstCleanup/CreateClusterExtension/DeferCleanup when
making this change.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a06ba30c-decf-499d-8332-bb07c1f4ea4b

📥 Commits

Reviewing files that changed from the base of the PR and between 40473ed and 685cfb0.

📒 Files selected for processing (2)

• openshift/tests-extension/.openshift-tests-extension/openshift_payload_olmv1.json
• openshift/tests-extension/test/olmv1-boxcutter.go

[camilamacedo86]

/test e2e-aws-techpreview-olmv1-ext

[bandrade]

/lgtm

[tmshort]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bandrade]

/label qe-approved
/verified by @bandrade

[openshift-ci-robot]

@camilamacedo86: This pull request references OPRUN-4228 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@bandrade: This PR has been marked as verified by @bandrade.

Details

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.