Skip to content

OCPQE-31553: update preflight permission case#686

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
kuiwang02:fixprepermision
Apr 1, 2026
Merged

OCPQE-31553: update preflight permission case#686
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
kuiwang02:fixprepermision

Conversation

@kuiwang02
Copy link
Copy Markdown
Contributor

@kuiwang02 kuiwang02 commented Mar 31, 2026

/cc @Xia-Zhao-rh @jianzhangbjz @bandrade

Update test cases to use clusterobjectsets/finalizers instead of clusterextensionrevisions/finalizers following product code changes.

wait 682 to be merged

Assisted-By: Claude Code

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 31, 2026

@kuiwang02: This pull request references OCPQE-31553 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/cc @Xia-Zhao-rh @jianzhangbjz @bandrade

Update test cases to use clusterobjectsets/finalizers instead of clusterextensionrevisions/finalizers following product code changes.

wait 682 to be merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 12f90009-ea0b-4a3c-9347-eb2e8686cc07

📥 Commits

Reviewing files that changed from the base of the PR and between 056fa80 and ebab83b.

📒 Files selected for processing (4)
  • openshift/tests-extension/pkg/bindata/qe/bindata.go
  • openshift/tests-extension/test/qe/specs/olmv1_ce.go
  • openshift/tests-extension/test/qe/testdata/olm/sa-nginx-insufficient-operand-rbac-boxcutter.yaml
  • openshift/tests-extension/test/qe/testdata/olm/sa-nginx-limited-boxcutter.yaml

Walkthrough

This change updates RBAC rule definitions and test expectations across four files, replacing the resource clusterextensionrevisions/finalizers with clusterobjectsets/finalizers for the olm.operatorframework.io API group while preserving the update verb and rule structure.

Changes

Cohort / File(s) Summary
Generated Bindata Assets
openshift/tests-extension/pkg/bindata/qe/bindata.go
Updated embedded RBAC rule definitions in generated YAML templates, changing finalizer resource from clusterextensionrevisions/finalizers to clusterobjectsets/finalizers in the olm.operatorframework.io API group rules.
Test Specifications
openshift/tests-extension/test/qe/specs/olmv1_ce.go
Updated Boxcutter-runtime test expectations for clusterextension preflight/finalizer permissions, reflecting the resource change from clusterextensionrevisions/finalizers to clusterobjectsets/finalizers in multiple test assertions and comments.
Test Data - RBAC Templates
openshift/tests-extension/test/qe/testdata/olm/sa-nginx-insufficient-operand-rbac-boxcutter.yaml, openshift/tests-extension/test/qe/testdata/olm/sa-nginx-limited-boxcutter.yaml
Updated ClusterRole RBAC rules in both test data files, changing the olm.operatorframework.io API group resource from clusterextensionrevisions/finalizers to clusterobjectsets/finalizers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 31, 2026

@kuiwang02: This pull request references OCPQE-31553 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/cc @Xia-Zhao-rh @jianzhangbjz @bandrade

Update test cases to use clusterobjectsets/finalizers instead of clusterextensionrevisions/finalizers following product code changes.

wait 682 to be merged

Assisted-By: Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kuiwang02
Copy link
Copy Markdown
Contributor Author

it is included in #687
so, if #687 is merged, could close this ticket.

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Mar 31, 2026

/hold
Until Either #687 or #682 merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2026
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Mar 31, 2026

/unhold
#682 merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2026
@kuiwang02
Copy link
Copy Markdown
Contributor Author

/verified by @kuiwang02

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 31, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@kuiwang02: This PR has been marked as verified by @kuiwang02.

Details

In response to this:

/verified by @kuiwang02

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianzhangbjz
Copy link
Copy Markdown
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, kuiwang02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

@kuiwang02: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 52410d5 into openshift:main Apr 1, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants