This repository was archived by the owner on Aug 29, 2018. It is now read-only.
Rest API Deployment support for passing the artifact url parameter#4078
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Nov 6, 2013
Merged
Conversation
Contributor
|
[test] |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/5187/) |
Contributor
Author
|
[test] |
Contributor
There was a problem hiding this comment.
Is there a reason you're limiting this to just http and https? What about ftp? I'm not sure there's really a need to test the scheme, is there?
Contributor
Author
There was a problem hiding this comment.
Good point. Added support for ftp. The purpose of the http, https, and ftp are to prevent a user from mistyping the artifact url.
…th associated tests in the broker and node. Enabling the artifact url param in the rest models.
Contributor
|
[merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/5187/) (Image: devenv_3999) |
|
Evaluated for online up to 73fd96c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the branch holding the work to get the artifact url parameter passed through on the binary deployment rest api.