Make warning message more accurate when adding invalid secret/configMap

[jhadvig]

This fix is based from https://bugzilla.redhat.com/show_bug.cgi?id=1529467 where we suggested that best fix would be just warn user that the envVar is invalid.
@jwforres @spadgett PTAL

[spadgett]

The message was saying just the invalid keys won't be added, not that the secret won't be added. But maybe the wording was confusing.

I think we still need to tell the user what will happen. How about...?

Some of the keys for {{ctrl.apiObject.kind | humanizeKind}} <strong>{{ctrl.apiObject.metadata.name}}</strong> are not valid environment variable names.
Only {{ctrl.apiObject.kind | humanizeKind}} keys with valid names will be added as environment variables.

cc @jwforres

[jhadvig]

that sounds good to me 👍

[jwforres]

So I like @spadgett's message better generally than what is there. My point in the bug is that we say "Some" even when its really "All"

[jwforres]

If we say

{{ctrl.apiObject.kind | humanizeKind}} <strong>{{ctrl.apiObject.metadata.name}}</strong> contains keys that are not valid environment variable names.
Only {{ctrl.apiObject.kind | humanizeKind}} keys with valid names will be added as environment variables.

then one message works generally

[jwforres]

will need to update that first humanized string so the first letter is capitalized, i.e. "Config map"

[spadgett]

That message is better 👍

Will need upperFirst to capitalize the first word in the sentence.

{{ctrl.apiObject.kind | humanizeKind | upperFirst}} <strong>{{ctrl.apiObject.metadata.name}}</strong> ...

[jwforres]

IIRC the capitalize option on humanizeKind filter capitalizes both words? if so then you can just wrap this humanizeKind filter call in parens and pass it to _.capitalize

[spadgett]

@jwforres We were making the same comment at the same time :)

I think upperFirst filter should do what we want.

[jhadvig]

@spadgett @jwforres comments addressed

[spadgett]

/lgtm

[openshift-merge-robot]

Automatic merge from submit-queue.