Fix swallowed keys in BC editor#456
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Aug 23, 2016
Merged
Conversation
benjaminapetersen
force-pushed
the
bug-1369338-bc-edit-sync
branch
from
b243bc5 to
db507b6
Compare
Contributor
Author
|
[test] |
|
Evaluated for origin web console test up to db507b6 |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/336/) |
Member
|
[merge] |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/337/) |
|
Evaluated for origin web console merge up to db507b6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates the
$filter('envVarsPair')which was swallowing duplicate keys when converting array to hash, and is probably no longer needed since we are not using<osc-key-values>.@jwforres @spadgett @jhadvig