Resolve parameters when displaying template images#713
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Oct 24, 2016
Merged
Resolve parameters when displaying template images#713openshift-bot merged 1 commit intoopenshift:masterfrom
openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
Member
Author
jwforres
approved these changes
Oct 24, 2016
Member
jwforres
left a comment
jwforres
left a comment
There was a problem hiding this comment.
otherwise LGTM, can merge after you update the comment
| if (containers) { | ||
| angular.forEach(containers, function(container) { | ||
| var image = container.image; | ||
| // If `container.image` is empty, look to see if it's set from an |
If a template image includes a parameter value, resolve the variable values when showing it in the summary at the top of the page. https://bugzilla.redhat.com/show_bug.cgi?id=1386775
spadgett
force-pushed
the
resolve-template-image-params
branch
from
beb70da to
0ed4eee
Compare
Member
Author
|
[merge] |
|
Evaluated for origin web console merge up to 0ed4eee |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin web console test up to 0ed4eee |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/567/) (Base Commit: 3d86cf3) |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/569/) (Base Commit: 09593f1) |
spadgett
pushed a commit
to spadgett/origin-web-console
that referenced
this pull request
Oct 24, 2016
…-params Merged by openshift-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a template image includes a parameter value, resolve the variable values when showing it in the summary at the top of the page.
https://bugzilla.redhat.com/show_bug.cgi?id=1386775
@jwforres PTAL