Don't allow scaling of in progress k8s deployments#733
Merged
openshift-bot merged 2 commits intoopenshift:masterfrom Oct 26, 2016
Merged
Don't allow scaling of in progress k8s deployments#733openshift-bot merged 2 commits intoopenshift:masterfrom
openshift-bot merged 2 commits intoopenshift:masterfrom
Conversation
jwforres
reviewed
Oct 25, 2016
| // deployment selector with active replicas. | ||
| var numActive = 0; | ||
| _.each(replicaSets.by('metadata.name'), function(replicaSet) { | ||
| if (!deploymentSelector.matches(replicaSet) || !replicaSet.status.replicas) { |
Member
There was a problem hiding this comment.
is matches the right check here? shouldn't it be comparing the labelSelector of the deployment to the labelSelector of the replicaSet? matches is going to checks the labels on the replicaSet, covers would check the labelSelector
spadgett
force-pushed
the
disable-scaling-rolling-deployments
branch
from
4a72678 to
2c9fa8c
Compare
Member
Author
|
@jwforres thanks, updated |
Member
|
@spadgett were you using matches anywhere else in the deployment/replicaset rollup that we should have been using covers instead? |
Member
|
actually i see you updated another one in your latest commit, thanks [merge] |
|
Evaluated for origin web console merge up to 2c9fa8c |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/577/) (Base Commit: 9ba5318) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1383042
@jwforres PTAL