Fix canI checks that need to be wrapped in parens #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@spadgett PTAL, for 1.4 |
spadgett
approved these changes
Nov 8, 2016
Member
|
@jwforres LGTM, but I worry we have this problem in other places |
Member
Author
|
yep i just found another one |
jwforres
force-pushed
the
double-add-storage-actions
branch
from
6f403da to
e78949a
Compare
jwforres
changed the title
Member
spadgett
reviewed
Nov 8, 2016
Member
spadgett
left a comment
spadgett
left a comment
There was a problem hiding this comment.
LGTM except for one additional canI check that needs parens
jwforres
force-pushed
the
double-add-storage-actions
branch
from
e78949a to
ea5990f
Compare
jwforres
force-pushed
the
double-add-storage-actions
branch
from
ea5990f to
257d1c6
Compare
Member
Author
|
[merge] |
|
Evaluated for origin web console merge up to 257d1c6 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/668/) (Base Commit: 61b1b3f) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1389734
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1391879