Build config source fixes #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
force-pushed
the
binary-builds
branch
from
0217a29 to
e875ae9
Compare
* Show message when there are no editable source types in the editor * Show the binary input as file in the browse page configuration tab * Show the Dockerfile on the browse page if it exists, even when `spec.strategy.type` isn't `Docker` Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1393803
spadgett
force-pushed
the
binary-builds
branch
from
e875ae9 to
9946f67
Compare
Member
|
[merge] you should probably explain the fix in the bug so they don't try to re-open it |
|
Evaluated for origin web console merge up to 9946f67 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/672/) (Base Commit: abcecfa) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec.strategy.typeisn'tDockerFixes https://bugzilla.redhat.com/show_bug.cgi?id=1393803
@jwforres PTAL