Show build status message when it exists #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
Member
Author
|
Note there are currently some issues with the messages showing up so i could only test cancelled openshift/origin#12146 |
Member
|
Should we add it to the build config page as well for latest build? |
jwforres
force-pushed
the
build-failure-reason
branch
from
fcbaf7a to
f8229ec
Compare
Member
Author
|
@spadgett updated |
spadgett
approved these changes
Dec 6, 2016
Member
spadgett
left a comment
spadgett
left a comment
There was a problem hiding this comment.
LGTM, just one nit on the commented out code
app/views/browse/build-config.html
Outdated
| <td data-title="Status"> | ||
| <div row class="status"> | ||
| <build-status build="build"></build-status> | ||
| <!-- <build-status build="build"></build-status> --> |
jwforres
force-pushed
the
build-failure-reason
branch
from
f8229ec to
eeb4ffa
Compare
Member
Author
|
fixed [merge] |
|
Evaluated for origin web console merge up to eeb4ffa |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/814/) (Base Commit: a8bd114) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://trello.com/c/Of6LXNUi