Add build failure reasons to monitoring and overview pages #996
Conversation
|
@spadgett missed this two pages, i couldn't decide between the long or short form on the overview |
spadgett
left a comment
spadgett
left a comment
There was a problem hiding this comment.
Changes LGTM, just one question on the build-status directive.
| <small>created <span am-time-ago="build.metadata.creationTimestamp"></span></small> | ||
| </div> | ||
| <div class="list-group-item-text"> | ||
| <build-status build="build"></build-status> |
There was a problem hiding this comment.
Should we delete the build-status directive if it's not used? Or update it to show the reason or message instead?
|
Realized this change was removing the duration completely from the monitoring page, i'm updating build-status directive for when we still need status + duration, but using the longer form duration on this page there isn't really enough space for it when the events sidebar is expanded.
|
|
Yeah I think we need to use "1m 48s" format, maybe small / text-muted? |
|
i dunno about changing the font style, in some cases its read as part of a statement like with Cancelled |
jwforres
force-pushed
the
build-status-other-pages
branch
from
9466db7 to
aba973e
Compare
|
updated PTAL |
|
[merge] |
|
Evaluated for origin web console merge up to aba973e |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/820/) (Base Commit: 8fd9c66) |
3 participants
No description provided.