Failed to resolve ImageStreamTag in deployment

[mfojtik]

Reproduce on latest master:

$ oc new-project stage
$ oc create -f https://raw.githubusercontent.com/arilivigni/openshift-ci-pipeline/master/sample-app/sample-app-template.json
$ oc start-build sample-app --wait --follow
$ oc deploy sample-app --latest

What I see, is this error in the Pod event log:

Failed to pull image "sample-app:latest": Error: image library/sample-app:latest not found

Additionally:

$ oc describe istag/sample-app:latest
Name:       sha256:79bd15f334544d39d726c1b5e178085bb48425a9a7d4dfbf2dc4d376cb192e24
Created:    12 minutes ago
Docker Image:   172.30.167.193:5000/stage/sample-app@sha256:79bd15f334544d39d726c1b5e178085bb48425a9a7d4dfbf2dc4d376cb192e24
...

$ oc describe dc/sample-app
Name:       sample-app
Created:    15 minutes ago
Labels:     app=sample-app
Annotations:    openshift.io/generated-by=OpenShiftNewApp
Latest Version: 2
Triggers:   Config, Image(sample-app@latest, auto=false)
Strategy:   Rolling
Template:
  Selector: app=sample-app,deploymentconfig=sample-app
  Replicas: 1
  Containers:
  NAME      IMAGE           ENV
  sample-app    sample-app:latest

[mfojtik]

OK, this is strange but when I deleted that project and created it from scratch, it actually deployed automatically after build even that auto=false...

EDIT: After I removed the project again and re-created it from the original steps, I get the IST not resolved again...

[mfojtik]

So when I set automatic:false it will not resolve the imagestreamtag... That seems to be the problem here.

[mfojtik]

So further investigation reveals that we never update the DeploymentConfig when the "automatic:false", which means the Image in ContainerSpec is never resolved into DockerPullSpec based on the ImageStreamTag.

The code is here: https://github.com/openshift/origin/blob/master/pkg/deploy/controller/imagechange/controller.go#L44

[mfojtik]

@ironcladlou FYI

[0xmichalis]

First bug in here is in oc status. Before I manually trigger the deployment:

$ oc status
In project stage on server https://localhost:8443

svc/sample-app - 172.30.154.201:8080
  dc/sample-app deploys istag/sample-app:latest <-
    bc/sample-app builds https://github.com/mfojtik/sample-app.git with openshift/ruby:latest 
      #1 build succeeded 45 seconds ago - 85d983b: Cleanup (Michal Fojtik <mfojtik@redhat.com>)
    #1 deployment waiting on image or update

View details with 'oc describe <resource>/<name>' or list everything with 'oc get all'.

It should warn me that the image is available and I just need to manually trigger since dc.spec.triggers[1].automatic == false.

[0xmichalis]

So when I set automatic:false it will not resolve the imagestreamtag... That seems to be the problem here.

I see the istag resolved from sample-app:latest to the full spec in the registry

$ oc describe istag sample-app:latest
Name:       sha256:21cce35a1e1974b0d3fe78d347b1b8e0f6e295f62b8fc9a28f047df31c21d123
Created:    29 minutes ago
Labels:     <none>
Annotations:    openshift.io/image.managed=true
Docker Image:   172.30.59.130:5000/stage/sample-app@sha256:21cce35a1e1974b0d3fe78d347b1b8e0f6e295f62b8fc9a28f047df31c21d123

$ oc describe dc/sample-app
Name:       sample-app
Created:    30 minutes ago
Labels:     app=sample-app
Annotations:    openshift.io/generated-by=OpenShiftNewApp
Latest Version: 2
Triggers:   Config, Image(sample-app@latest, auto=false)
Strategy:   Rolling
Template:
  Selector: app=sample-app,deploymentconfig=sample-app
  Replicas: 1
  Containers:
  NAME      IMAGE                                                       ENV
  sample-app    172.30.59.130:5000/stage/sample-app@sha256:21cce35a1e1974b0d3fe78d347b1b8e0f6e295f62b8fc9a28f047df31c21d123 

[0xmichalis]

@mfojtik you also have the following streams, right?

$ oc create -f https://raw.githubusercontent.com/openshift/origin/master/examples/image-streams/image-streams-centos7.json -n openshift

[mfojtik]

yes i do
On Feb 1, 2016 4:09 PM, "Michail Kargakis" notifications@github.com wrote:

@mfojtik https://github.com/mfojtik you also have the following stream,
right?

$ oc create -f https://raw.githubusercontent.com/openshift/origin/master/examples/image-streams/image-streams-centos7.json -n openshift

—
Reply to this email directly or view it on GitHub
#6934 (comment).

[soltysh]

So when I set automatic:false it will not resolve the imagestreamtag... That seems to be the problem here.

That's exactly the root cause of your problem. Only ImageChange trigger is capable of resolving IST correctly, since in your example it's turned off the Deployment will be created from the exact PodTemplate you specified, in your case: image: sample-app:latest which won't work, obviously. This is not a bug.

[mfojtik]

@soltysh it depends on how you define "bug" here. If automatic=false disable IST resolving then we should at least tweak its API description:

Automatic means that the detection of a new tag value should result in a new deployment.

What I expected here is that the IST gets resolved, because I have ICT defined and I want it to become the Container->Image. What I don't want is the new tag result into a new deployment, which is what that description is saying. So I can do manual deploy when I decide to do it.

cc @bparees @smarterclayton