Fix router e2e validation for docker 1.9#7574
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Feb 24, 2016
marun:fix-docker-1.9-router-e2e
Merged
Fix router e2e validation for docker 1.9#7574openshift-bot merged 1 commit intoopenshift:masterfrom marun:fix-docker-1.9-router-e2e
openshift-bot merged 1 commit intoopenshift:masterfrom
marun:fix-docker-1.9-router-e2e
Conversation
Router validation previously assumed that the router would be reachable via the docker bridge's well known default address (172.17.42.1). This default has been removed as of docker 1.9 and the router ip can be more reliably determined via an 'oc get' call.
Contributor
Author
Contributor
Author
|
[test] |
Contributor
Author
|
For reference: moby/moby#17305 |
Contributor
|
Evaluated for origin test up to 98d2747 |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1547/) |
Contributor
|
lgtm [merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1547/) (Image: devenv-rhel7_3527) |
Contributor
|
Evaluated for origin merge up to 98d2747 |
openshift-bot
pushed a commit
that referenced
this pull request
Feb 24, 2016
Merged by openshift-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Router validation previously assumed that the router would be
reachable via the docker bridge's well known default address
(172.17.42.1). This default has been removed as of docker 1.9 and the
router ip can be more reliably determined via an 'oc get' call.