oc export does not work for image streams

[tnozicka]

If you export ImageStream having Spec.DockerImageRepository all of its tags are striped and not exported!
I probably found the line causing this 181: https://github.com/openshift/origin/blob/master/pkg/cmd/cli/cmd/exporter.go
IMHO you should copy tags from spec and status as well.

Version

oc v1.1.4
kubernetes v1.2.0-origin-41-g91d3e75

Steps To Reproduce

1. oc new-project original-project
2. oc new-app centos/ruby-22-centos7~https://github.com/openshift/ruby-hello-world.git
3. oc new-project import
4. oc export is,bc -o yaml -n original-project | oc create -f - -n import
5. oc start-build ruby-hello-world -n import

Current Result

Error from server: imageStreamTag "ruby-22-centos7:latest" not found

Expected Result

No error

[liggitt]

Status won't be respected in import, so it's not appropriate to include in export

[tnozicka]

@liggitt you could merge tags from status with spec a write the whole thing into spec

[tnozicka]

btw. by accident @kadel found out that if you remove annotations from ImageStream definitions

1. oc new-project original-project
2. oc new-app centos/ruby-22-centos7~https://github.com/openshift/ruby-hello-world.git
3. oc new-project import
4. oc export bc -o yaml -n original-project | oc create -f - -n import
5. oc export is ruby-hello-world -o yaml -n original-project | oc create -f - -n import
6. oc export is ruby-22-centos7 -o yaml -n original-project | sed '/annotations/,+2d' | oc create -f - -n import
7. oc start-build ruby-hello-world -n import

Now it works with pull on demand. But the tags are still not exported, just recreated.

[smarterclayton]

We need to figure out whether we want to preserve spec tags or make them exact (or do both). I.e. if you're a user exporting an app, do you want to export the flow (where the images come from) or the EXACT images.

[miminar]

To preserve the is as is, we already have the oc get is/name and oc export --raw is/name. To make the exported image stream usable, we could:

1. remove DockerImageRepositoryCheckAnnotation from annotations
2. make ImageStreamImage references in the spec for all the built images stored in status; I'm reluctant to do it by default though; ImageStreamImage reference is usable only if the import happens in the same cluster; otherwise DockerImage would have to be employed; this calls for some distinction flag like --for-cluster-import or --for=<local|remote>

[smarterclayton]

We are probably going to move to a model where all clusters have a public registry name, so images are available outside. By doing so we'd at least guarantee the content is accessible. We could potentially decide how to handle each tag based on its source. External images get turned from tags to digests. ImageStreamTags get turned into imagestreamimages.

[openshift-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale