Set xff headers for reencrypt[ed] routes.#10318
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Aug 16, 2016
Merged
Set xff headers for reencrypt[ed] routes.#10318openshift-bot merged 1 commit intoopenshift:masterfrom
openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
Contributor
Author
|
[test] |
Contributor
|
Evaluated for origin test up to 673823f |
Contributor
|
LGTM |
Contributor
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7704/) |
Contributor
|
LGTM [merge] BTW there are other problems where the reencryped routes are different from the edge termination. @rajatchopra is looking into those for https://trello.com/c/0BaxAOK9 . If you happen to spot any other gaps, please flag them there. Thanks |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7965/) (Image: devenv-rhel7_4840) |
Contributor
Author
|
Looks like merge failed due to jenkins having too many open files. |
Contributor
|
re-[merge] |
Contributor
|
Evaluated for origin merge up to 673823f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bdecoste noticed we don't set xff headers for re-encrypted routes. Fix to add 'em to the haproxy config.
@knobunc @rajatchopra PTAL thx.