Ignore negative value of grace-period#10350
Conversation
|
@xiangpengzhao thanks for the PR! You can add an example right in the examples section of the command and then run |
|
[test] |
|
Evaluated for origin test up to 3d5289a |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7803/) |
3d5289a to
7dcd7d0
Compare
|
Just modify an existed example and add description. PTAL @fabianofranz . Thanks! |
|
@xiangpengzhao just go ahead and add a separate example for |
7dcd7d0 to
0cb8cb9
Compare
|
Thanks @fabianofranz ! Agreed. I add two separate examples for flags |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7924/) (Image: devenv-rhel7_4830) |
|
Evaluated for origin merge up to 0cb8cb9 |
|
Origin Action Required: Please contact #openshift-dev to have this pull request manually reviewed and tested |
If the value of flag
--grace-periodpassed tooadm manage-nodeis negative, we'd better ignore it.BTW, should we add an example of
--grace-periodin oadm_by_example_content.adoc#oadm-manage-node ?