Skip to content

Ignore negative value of grace-period#10350

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
xiangpengzhao:fix-graceperiod
Aug 15, 2016
Merged

Ignore negative value of grace-period#10350
openshift-bot merged 1 commit intoopenshift:masterfrom
xiangpengzhao:fix-graceperiod

Conversation

@xiangpengzhao
Copy link
Copy Markdown
Contributor

If the value of flag --grace-period passed to oadm manage-node is negative, we'd better ignore it.

BTW, should we add an example of --grace-period in oadm_by_example_content.adoc#oadm-manage-node ?

@fabianofranz
Copy link
Copy Markdown
Member

@xiangpengzhao thanks for the PR! You can add an example right in the examples section of the command and then run hack/update-generated-docs.sh which will update the examples document automatically.

@fabianofranz
Copy link
Copy Markdown
Member

[test]

@openshift-bot
Copy link
Copy Markdown
Contributor

Evaluated for origin test up to 3d5289a

@openshift-bot
Copy link
Copy Markdown
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7803/)

@xiangpengzhao
Copy link
Copy Markdown
Contributor Author

Just modify an existed example and add description. PTAL @fabianofranz . Thanks!

@fabianofranz
Copy link
Copy Markdown
Member

@xiangpengzhao just go ahead and add a separate example for --grace-period=60 instead of changing the existing one. No problem if they are similar. Having simple examples where each demonstrate one single feature of the command is encouraged and improve the understandability for our users. ;)

@xiangpengzhao
Copy link
Copy Markdown
Contributor Author

Thanks @fabianofranz ! Agreed. I add two separate examples for flags --grace-period and --force. PTAL.

@fabianofranz
Copy link
Copy Markdown
Member

LGTM [merge]

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 15, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7924/) (Image: devenv-rhel7_4830)

@openshift-bot
Copy link
Copy Markdown
Contributor

Evaluated for origin merge up to 0cb8cb9

@openshift-bot
Copy link
Copy Markdown
Contributor

Origin Action Required: Please contact #openshift-dev to have this pull request manually reviewed and tested

@openshift-bot openshift-bot merged commit e69938c into openshift:master Aug 15, 2016
@xiangpengzhao xiangpengzhao deleted the fix-graceperiod branch October 18, 2016 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants