add some optimized functions in example/deployment #10372
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Aug 15, 2016
Merged
add some optimized functions in example/deployment #10372openshift-bot merged 1 commit intoopenshift:masterfrom
openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
Contributor
Author
|
@mfojtik PTAL |
Contributor
|
@yuexiao-wang looks good to me, thanks! Can you please reword the commit message and make it more descriptive? |
Contributor
Author
|
Hi mfojtik, |
yuexiao-wang
force-pushed
the
optimize-deploy-example
branch
2 times, most recently
from
fa1e15c to
345fcdb
Compare
Contributor
|
@yuexiao-wang I don't see the commit message changed :-) |
Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
yuexiao-wang
force-pushed
the
optimize-deploy-example
branch
from
345fcdb to
2a42d91
Compare
Contributor
Author
|
@mfojtik PTAL |
Contributor
Author
|
@mfojtik PTAL |
Contributor
|
LGTM [merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7912/) (Image: devenv-rhel7_4828) |
Contributor
|
Evaluated for origin merge up to 2a42d91 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is poorly readable that the incoming parameters of function is so lengthiness. I add some functions to instead of lengthiness parameters which is clearly understanded
Signed-off-by: yuexiao-wang wang.yuexiao@zte.com.cn