Remain in the current project at login if possible#10378
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Aug 12, 2016
liggitt:login-project
Merged
Remain in the current project at login if possible#10378openshift-bot merged 1 commit intoopenshift:masterfrom liggitt:login-project
openshift-bot merged 1 commit intoopenshift:masterfrom
liggitt:login-project
Conversation
Contributor
|
The change LGTM, can you add tests, I see we have 0 tests in that area and that freaks me out a bit. |
Contributor
Author
it's not well-structured for mocking client calls for unit tests, reworking that is a bigger change than I want to make at the moment. test-cmd also exercises login quite a bit. |
Contributor
Author
|
[test] |
Contributor
|
Evaluated for origin test up to 2321354 |
Contributor
Author
|
[merge] |
Contributor
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7853/) |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7881/) (Image: devenv-rhel7_4815) |
Contributor
|
AWS failure: re-[merge] |
Contributor
|
Evaluated for origin merge up to 2321354 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On login, we were listing the projects available to the current user, selecting the current one if it is in that list, defaulting to the first project in the list otherwise
If this is done right after a project is created or a role is granted, the project list cache may not include the project yet. If the list of projects does not include our current one, attempt a direct get before switching to a different project.
Fixes #10274