Deprecate --list option from volumes cmd#10457
Conversation
juanvallejo
force-pushed
the
jvallejo_remove-list-option-from-oc-set-volumes-help
branch
from
1f41ff2 to
ced3ee6
Compare
|
[test] |
Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1366560 The `--list` flag in `oc volumes` and `oc set volumes` is redundant. The command does not take more than one operation at a time (add|remove|list) and its default operation when none is provided is to list volumes and volume mounts for the given resource. The following commands give the exact same output: - `$ oc set volumes dc database` - `$ oc set volumes dc database --list=true` - `$ oc set volumes dc database --list=false` ``` deploymentconfigs/database empty directory as ruby-helloworld-data mounted at /var/lib/mysql/data ``` This patch deprecates the `--list` flag from the command's help output.
juanvallejo
force-pushed
the
jvallejo_remove-list-option-from-oc-set-volumes-help
branch
from
ced3ee6 to
af79d7d
Compare
juanvallejo
changed the title
volumes cmdvolumes cmd
|
Evaluated for origin test up to af79d7d |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7999/) |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7999/) (Image: devenv-rhel7_4866) |
|
Evaluated for origin merge up to af79d7d |
juanvallejo
deleted the
jvallejo_remove-list-option-from-oc-set-volumes-help
branch
|
Is --list the default action for all our set commands? If not, I prefer being able to pass an explicit --list flag to all of them without some of them complaining about it being deprecated |
|
@liggitt |
4 participants
Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1366560
The
--listflag inoc volumesandoc set volumesis redundant. Thecommand does not take more than one operation at a time (add|remove|list)
and its default operation when none is provided is to list volumes and
volume mounts for the given resource.
The following commands give the exact same output:
$ oc set volumes dc database$ oc set volumes dc database --list=true$ oc set volumes dc database --list=falseThis patch removes the
--listflag from the command's help output.cc @fabianofranz