deploy: don't requeue configs on stream updates yet#10744
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Sep 2, 2016
0xmichalis:disable-requeues-on-stream-events
Merged
deploy: don't requeue configs on stream updates yet#10744openshift-bot merged 1 commit intoopenshift:masterfrom 0xmichalis:disable-requeues-on-stream-events
openshift-bot merged 1 commit intoopenshift:masterfrom
0xmichalis:disable-requeues-on-stream-events
Conversation
Contributor
|
[test] |
Contributor
|
LGTM (approved for 1.3) [merge] |
| @@ -47,8 +47,9 @@ func NewDeploymentTriggerController(dcInformer, streamInformer framework.SharedI | |||
| c.dcStoreSynced = dcInformer.HasSynced | |||
|
|
|||
| streamInformer.AddEventHandler(framework.ResourceEventHandlerFuncs{ | |||
Contributor
There was a problem hiding this comment.
is there any point to adding an event handler with no functions registered?
Contributor
Author
There was a problem hiding this comment.
Not really. I can comment it out if you want
Contributor
|
Evaluated for origin test up to 7876b26 |
Contributor
|
[merge] |
Contributor
|
Evaluated for origin merge up to 7876b26 |
liggitt
added
the
approved
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8627/) |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8644/) (Image: devenv-rhel7_4970) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mfojtik we still have the image change controller up and running so we don't need to do this just yet
I would like to have it for 1.3.
[test]