Skip to content

[DO NOT MERGE] UPSTREAM: 37288: Improve quota scope descriptions#11988

Closed
juanvallejo wants to merge 1 commit into
openshift:masterfrom
juanvallejo:jvallejo/improve-quota-scope-descriptions
Closed

[DO NOT MERGE] UPSTREAM: 37288: Improve quota scope descriptions#11988
juanvallejo wants to merge 1 commit into
openshift:masterfrom
juanvallejo:jvallejo/improve-quota-scope-descriptions

Conversation

@juanvallejo

@juanvallejo juanvallejo commented Nov 21, 2016

Copy link
Copy Markdown
Contributor

@fabianofranz

Copy link
Copy Markdown
Contributor

SGTM

@juanvallejo juanvallejo force-pushed the jvallejo/improve-quota-scope-descriptions branch from 3c31606 to a5e27ab Compare November 22, 2016 14:54
@juanvallejo juanvallejo changed the title UPSTREAM: 0000: Improve quota scope descriptions UPSTREAM: 37288: Improve quota scope descriptions Nov 22, 2016
@ncdc ncdc changed the title UPSTREAM: 37288: Improve quota scope descriptions [DO NOT MERGE] UPSTREAM: 37288: Improve quota scope descriptions Nov 22, 2016
@ncdc

ncdc commented Nov 22, 2016

Copy link
Copy Markdown
Contributor

This isn't going to go in upstream as is because it mentions builds. I also don't think this warrants an UPSTREAM pull here. It can wait for the next rebase after the one in progress (i.e. for 1.6) in whatever shape it's in at that point.

@jwforres

@jwforres

Copy link
Copy Markdown
Member

Agree with both points here.

On Tue, Nov 22, 2016 at 11:00 AM, Andy Goldstein notifications@github.com
wrote:

This isn't going to go in upstream as is because it mentions builds. I
also don't think this warrants an UPSTREAM pull here. It can wait for the
next rebase after the one in progress (i.e. for 1.6) in whatever shape it's
in at that point.

@jwforres https://github.com/jwforres


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11988 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZk7Xueq8_zqyYKz35o1Wksf4v5D78Qks5rAxGVgaJpZM4K4qhI
.

@fabianofranz

Copy link
Copy Markdown
Contributor

Let's rephrase it in the upstream PR, mention the upstream PR in a comment in the original issue and tag it with post-rebase so that we verify and close it once the next (1.6) rebase lands with the fix.

@juanvallejo juanvallejo deleted the jvallejo/improve-quota-scope-descriptions branch November 22, 2016 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants