Skip to content

fix cluster up extended test#17029

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
bparees:clusterup_extended
Oct 26, 2017
Merged

fix cluster up extended test#17029
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
bparees:clusterup_extended

Conversation

@bparees
Copy link
Copy Markdown
Contributor

@bparees bparees commented Oct 24, 2017

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 24, 2017
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Oct 24, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2017
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 24, 2017

/assign @csrwng
/unassign @mfojtik @deads2k

@openshift-ci-robot openshift-ci-robot assigned csrwng and unassigned mfojtik and deads2k Oct 24, 2017
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 24, 2017

@csrwng i'm not sure why this wasn't using --version=latest before but i think it should be for the bulk of the tests, no?

Adding another test that runs w/o --version=latest makes sense to me, but we can't do that right now because current master actually can't bring up v3.7-alpha1 anyway. so that's a follow up.

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

/test extended_clusterup

@bparees bparees force-pushed the clusterup_extended branch from 49e4712 to e2b3d21 Compare October 25, 2017 07:38
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2017
@bparees bparees force-pushed the clusterup_extended branch 2 times, most recently from ffc3ff2 to 00bf958 Compare October 25, 2017 09:08
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

/test extended_clusterup

@bparees bparees force-pushed the clusterup_extended branch from 00bf958 to 547c2c7 Compare October 25, 2017 09:24
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

/test extended_clusterup

@bparees bparees force-pushed the clusterup_extended branch from 547c2c7 to 406a664 Compare October 25, 2017 10:04
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

/test extended_clusterup

@bparees bparees force-pushed the clusterup_extended branch from 406a664 to 9605ac2 Compare October 25, 2017 11:26
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

/test extended_clusterup

@bparees bparees force-pushed the clusterup_extended branch from 9605ac2 to 8468209 Compare October 25, 2017 11:51
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

/test extended_clusterup

@bparees bparees force-pushed the clusterup_extended branch from 8468209 to 49e74f2 Compare October 25, 2017 14:59
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

/test extended_clusterup

@bparees bparees force-pushed the clusterup_extended branch from 49e74f2 to 1ceb3dc Compare October 25, 2017 15:44
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

/test extended_clusterup

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

@csrwng bump, this now passes the new cluster up extended test job i created (which just runs the clusterup.sh bucket)

@bparees bparees added the kind/bug Categorizes issue or PR as related to a bug. label Oct 25, 2017
@csrwng
Copy link
Copy Markdown
Contributor

csrwng commented Oct 25, 2017

@bparees I think that when we use --version="latest" infrastructure images are created with a pull policy of 'always'. If we want to test the local images, we may need to use the specific tag (git hash) that we used to build them.

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

@bparees I think that when we use --version="latest" infrastructure images are created with a pull policy of 'always'. If we want to test the local images, we may need to use the specific tag (git hash) that we used to build them.

ok. is there an easy way to grab that so i can just pass it to the script?

@csrwng
Copy link
Copy Markdown
Contributor

csrwng commented Oct 25, 2017

@stevekuznetsov ? ^^

@stevekuznetsov
Copy link
Copy Markdown
Contributor

stevekuznetsov commented Oct 25, 2017 

$ git log --pretty=%h -n 1

?

@stevekuznetsov
Copy link
Copy Markdown
Contributor

stevekuznetsov commented Oct 25, 2017

In our jobs we gather it like so:

https://github.com/openshift/aos-cd-jobs/blob/master/sjb/config/test_cases/test_branch_origin_extended_conformance_install_update.yml#L19

And use it like so:

https://github.com/openshift/aos-cd-jobs/blob/master/sjb/config/test_cases/test_branch_origin_extended_conformance_install_update.yml#L170

@bparees bparees force-pushed the clusterup_extended branch from 1ceb3dc to 5f75825 Compare October 25, 2017 21:14
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

/test extended_clusterup

@bparees bparees force-pushed the clusterup_extended branch from 5f75825 to e01bb9b Compare October 25, 2017 21:15
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

/test extended_clusterup

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

thanks @stevekuznetsov
@csrwng updated.

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

(and updated the jenkins job to set ORIGIN_COMMIT)

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

(well, trying to update the job. ci.jenkins looks dead)

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 25, 2017

the updated job definition is here:
https://github.com/openshift/aos-cd-jobs/pull/788/files

@csrwng
Copy link
Copy Markdown
Contributor

csrwng commented Oct 25, 2017

@bparees lgtm on passing test

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 26, 2017

/test extended_clusterup

1 similar comment
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 26, 2017

/test extended_clusterup

@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2017
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 26, 2017

passed cluster up test here:
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended_clusterup/11/consoleFull

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Oct 26, 2017

/retest

@0xmichalis
Copy link
Copy Markdown
Contributor

0xmichalis commented Oct 26, 2017

/cherrypick stage

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 26, 2017

@Kargakis: @Kargakis once the present PR merges, I will cherry-pick it on top of stage in a new PR and assign it to you.

Details

In response to this:

/cherrypick stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Oct 26, 2017

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 4d27cb3 into openshift:master Oct 26, 2017
@stevekuznetsov
Copy link
Copy Markdown
Contributor

stevekuznetsov commented Oct 26, 2017

I don't see the cherry-pick :( @Kargakis

@bparees bparees deleted the clusterup_extended branch November 2, 2017 16:23
@deads2k deads2k mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@csrwng csrwng

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bparees @openshift-merge-robot @csrwng @stevekuznetsov @0xmichalis @openshift-ci-robot @mfojtik @deads2k