Skip to content

Comments

Normalize image ref before pulling in cluster up#17395

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
liggitt:normalize-cluster-up
Nov 20, 2017
Merged

Normalize image ref before pulling in cluster up#17395
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
liggitt:normalize-cluster-up

Conversation

@liggitt
Copy link
Contributor

@liggitt liggitt commented Nov 20, 2017

Fixes #17394

/test extended_clusterup

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2017
This was referenced Nov 20, 2017
Closed
Merged
@bparees
Copy link
Contributor

bparees commented Nov 20, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2017
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 20, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, liggitt

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2017

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 6fc3c5a link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 20, 2017

Automatic merge from submit-queue (batch tested with PRs 17395, 17385).

@openshift-merge-robot openshift-merge-robot merged commit 5809056 into openshift:master Nov 20, 2017
@liggitt liggitt deleted the normalize-cluster-up branch November 21, 2017 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bparees bparees

@coreydaley coreydaley

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/post-rebase lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liggitt @bparees @openshift-merge-robot @openshift-ci-robot @coreydaley