Skip to content

[DO-NOT-MERGE] Only for testing purpose#17600

Closed
vikaschoudhary16 wants to merge 1 commit intoopenshift:masterfrom
vikaschoudhary16:test-cgroup-flake-fix
Closed

[DO-NOT-MERGE] Only for testing purpose#17600
vikaschoudhary16 wants to merge 1 commit intoopenshift:masterfrom
vikaschoudhary16:test-cgroup-flake-fix

Conversation

@vikaschoudhary16
Copy link
Copy Markdown
Contributor

@vikaschoudhary16 vikaschoudhary16 commented Dec 5, 2017

Just to see if these changes help with #16246
Signed-off-by: vikaschoudhary16 choudharyvikas16@gmail.com

@vikaschoudhary16
[DO-NOT-MERGE] Only for testing purpose
c0241c3 
Signed-off-by: vikaschoudhary16 <choudharyvikas16@gmail.com>
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 5, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vikaschoudhary16
We suggest the following additional approver: mfojtik

Assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 5, 2017
@vikaschoudhary16
Copy link
Copy Markdown
Contributor Author

vikaschoudhary16 commented Dec 5, 2017

/test extended_conformance_gce

1 similar comment
@vikaschoudhary16
Copy link
Copy Markdown
Contributor Author

vikaschoudhary16 commented Dec 6, 2017

/test extended_conformance_gce

@vikaschoudhary16
Copy link
Copy Markdown
Contributor Author

vikaschoudhary16 commented Dec 6, 2017

/retest

@vikaschoudhary16
Copy link
Copy Markdown
Contributor Author

vikaschoudhary16 commented Dec 6, 2017

/test extended_conformance_gce

@vikaschoudhary16
Copy link
Copy Markdown
Contributor Author

vikaschoudhary16 commented Dec 6, 2017

/test e2e_rhel

@vikaschoudhary16
Copy link
Copy Markdown
Contributor Author

vikaschoudhary16 commented Dec 6, 2017

https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended_conformance_gce/

@vikaschoudhary16 vikaschoudhary16 mentioned this pull request Dec 6, 2017
Closed
@vikaschoudhary16
Copy link
Copy Markdown
Contributor Author

vikaschoudhary16 commented Dec 6, 2017

/retest

@tnozicka
Copy link
Copy Markdown
Contributor

tnozicka commented Dec 6, 2017

FYI: I don't think submit queue recognizes [DO-NOT-MERGE] but it does recognize [WIP] prefix. If you want to prevent someone lgtm the change and SQ merging this right after you can use:
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2017
@vikaschoudhary16
Copy link
Copy Markdown
Contributor Author

vikaschoudhary16 commented Dec 6, 2017

/retest

3 similar comments
@vikaschoudhary16
Copy link
Copy Markdown
Contributor Author

vikaschoudhary16 commented Dec 7, 2017

/retest

@vikaschoudhary16
Copy link
Copy Markdown
Contributor Author

vikaschoudhary16 commented Dec 11, 2017

/retest

@vikaschoudhary16
Copy link
Copy Markdown
Contributor Author

vikaschoudhary16 commented Dec 14, 2017

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vikaschoudhary16 @openshift-ci-robot @tnozicka @openshift-merge-robot