Expose device-plugins directory in origin container#20351
Expose device-plugins directory in origin container#20351openshift-merge-robot merged 1 commit intoopenshift:masterfrom karmab:deviceplugin_mount
Conversation
openshift-ci-robot
added
the
size/XS
|
The goal of cluster up is to have a simple constrained way to support a limited developer use-case for running workloads. Platform development (apiserver, kubelet, controllers, kubelet, etc) are not goals for cluster up. As long as most (not all) of them are possible after the fact even if they aren't easy, it's ok. I don't really have an opinion about this because I don't know what it does. It appears to be constrained and it's not making a branching path, so I'll leave it up to @sjenning /assign @sjenning |
|
@deads2k missing this mount prevents using kubevirt on top of oc cluster up, which used to be a nice way to test it, and this seems like quite an easy fix |
|
/retest |
|
@sjenning can @karmab or I somehow assist with the PR? It would help us providing a limited KubeVirt demo.
@deads2k we use it for doing small demos. For developing and testing we have extra cluster: https://github.com/kubevirt/kubevirtci. Just to add explicitly that we do not intend to do more with this or minishift. |
|
/assign @vikaschoudhary16 |
|
/lgtm |
|
/retest |
|
This affects all applications providing device plugins, which I consider to to be a regular use-case (aka for users). What is needed to get this merged? |
It just fell off the radar. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, karmab, vikaschoudhary16 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@deads2k darn, this missed 3.10. When will 3.11 be around, or can we rquest backport to 3.10? |
|
@deads2k: cannot checkout 3.10: error checking out 3.10: exit status 1. output: error: pathspec '3.10' did not match any file(s) known to git. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-3.10 |
|
@deads2k: new pull request created: #20895 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OKD 3.11 includes the fix for openshift/origin#20351 so the relevant workaround is no longer required (and in fact appears to actually break the fix).
10 participants
No description provided.