Skip to content

UPSTREAM: 75772: Avoid panic in cronjob sorting#22442

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
soltysh:cronjob_panic
Apr 26, 2019
Merged

UPSTREAM: 75772: Avoid panic in cronjob sorting#22442
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
soltysh:cronjob_panic

Conversation

@soltysh
Copy link
Copy Markdown
Contributor

@soltysh soltysh commented Apr 1, 2019

/assign @mfojtik

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 1, 2019
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Apr 1, 2019

/hold
until after the rebase lands

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2019
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Apr 24, 2019

Rebase merged, and the PR already landed upstream, self-tagging.

@soltysh soltysh added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 24, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Apr 25, 2019

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b550022 into openshift:master Apr 26, 2019
@soltysh soltysh deleted the cronjob_panic branch May 16, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@mfojtik mfojtik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@soltysh @openshift-ci-robot @openshift-bot @mfojtik @openshift-merge-robot