Skip to content

switch klog#22503

Merged
deads2k merged 1 commit intoopenshift:masterfrom
deads2k:klog
Apr 9, 2019
Merged

switch klog#22503
deads2k merged 1 commit intoopenshift:masterfrom
deads2k:klog

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Apr 8, 2019

upstream switched to klog.

In a codebase this large, only having 1700 logging instances seems a little low. :(

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 8, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2019
@deads2k deads2k added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. queue/blocks-others queue/critical-fix labels Apr 8, 2019
soltysh
soltysh approved these changes Apr 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 8, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 8, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 8, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 8, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 8, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 8, 2019

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2019
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 8, 2019

looks like infrastructure

/retest

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 8, 2019

/test all

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 8, 2019

/retest

2 similar comments
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 9, 2019

/retest

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Apr 9, 2019

/retest

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 9, 2019

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-builds ead78d7 link /test e2e-aws-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 9, 2019

same unauthorized as known flakes, high likelihood of conflict, nothing merged since this tested, merging.

@deads2k deads2k merged commit c68d654 into openshift:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@bparees bparees Awaiting requested review from bparees

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. queue/blocks-others queue/critical-fix size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deads2k @openshift-bot @openshift-ci-robot @soltysh