get must-gather image from imagestream#22528
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Apr 22, 2019
Merged
get must-gather image from imagestream#22528openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/L
sanchezl
force-pushed
the
oc_admin_must-gather_image
branch
2 times, most recently
from
11277f2 to
6eeade6
Compare
sanchezl
force-pushed
the
oc_admin_must-gather_image
branch
from
6eeade6 to
9a7df80
Compare
sanchezl
force-pushed
the
oc_admin_must-gather_image
branch
from
9a7df80 to
774c412
Compare
openshift-ci-robot
added
do-not-merge/hold
sanchezl
force-pushed
the
oc_admin_must-gather_image
branch
from
774c412 to
6d1dc62
Compare
Contributor
Author
|
/test unit |
Contributor
Author
|
/retest |
Contributor
|
#22430 merged. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
deads2k
reviewed
Apr 16, 2019
| "k8s.io/kubernetes/pkg/kubectl/util/templates" | ||
|
|
||
| "github.com/openshift/client-go/image/clientset/versioned/typed/image/v1" | ||
|
|
Contributor
|
@sanchezl needs an e2e test before we can merge this |
Contributor
|
now, let's see if this works /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sanchezl, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User the
must-gatherImageStream in theopenshiftnamespace to get the image for themust-gathertool.