add e2e test for oc adm must-gather#22594
add e2e test for oc adm must-gather#22594openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/S
sanchezl
force-pushed
the
e2e-oc_adm_must-gather
branch
from
2a44d36 to
90f2c94
Compare
openshift-ci-robot
added
size/M
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/retest |
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
I'd like to see a followup with the fixes, still.
|
|
||
| import ( | ||
| g "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" |
There was a problem hiding this comment.
Please stick to the import organization we have, which is:
- builtin imports
- other imports
- k8s imports
- origin imports.
There was a problem hiding this comment.
Also wrt gomega we try to have an alias o is sufficient rather than importing everything into current namespace.
| oc := util.NewCLI("oc-adm-must-gather", util.KubeConfigPath()).AsAdmin() | ||
| g.It("runs successfully", func() { | ||
| tempDir, err := ioutil.TempDir("", "test.oc-adm-must-gather.") | ||
| Ω(err).ShouldNot(HaveOccurred()) |
There was a problem hiding this comment.
I'd prefer we stick with ANSI characters anywhere in our codebase.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sanchezl, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 participants
No description provided.