Skip to content

Disable resource quota#22618

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ravisantoshgudimetla:remove-resource-quota
Apr 24, 2019
Merged

Disable resource quota#22618
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ravisantoshgudimetla:remove-resource-quota

Conversation

@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor

Disable resource quota tests.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 21, 2019
@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

/retest

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Apr 22, 2019

@ravisantoshgudimetla time should be devoted to figuring out why the feature gate detection is wrong. It's probably looking locally at the way the test was executed maybe?

@sjenning
Copy link
Copy Markdown
Contributor

@deads2k can we merge this in the meantime? it is blocking a stream of things that needs to happen to disable some gates that have potential it cause us pain with no benefit in 4.1.

@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

time should be devoted to figuring out why the feature gate detection is wrong. It's probably looking locally at the way the test was executed maybe?

To be clear, I have spent some time debugging and the best thing that we could come up with is:

While I am not sure, if the above approach is clean, this would ensure that origin, individual operators and api repos are in sync to so that we don't see surprises when we are disabling/enabling certain tests.

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Apr 23, 2019

@deads2k can we merge this in the meantime? it is blocking a stream of things that needs to happen to disable some gates that have potential it cause us pain with no benefit in 4.1.

You should make a story to fix the debt coming off of this. Imagine one turned on in tech preview. You'd have no tests.

/approve

/assign @sjenning
if he wants to lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019
@sjenning
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ravisantoshgudimetla, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ed28c6c into openshift:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants