Skip to content

add minimal SCC changes to switch to CRD#22737

Merged
deads2k merged 3 commits intoopenshift:masterfrom
deads2k:scc-switch-3
May 2, 2019
Merged

add minimal SCC changes to switch to CRD#22737
deads2k merged 3 commits intoopenshift:masterfrom
deads2k:scc-switch-3

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented May 1, 2019 •
edited
Loading

SCC defaulting. It's important or the API contract is broken. This adds defaulting on write, not reads. This ok only because we have no old data. Doing it this way ensures that the data is in a good state. You cannot add new defaulting rules and only default on writing.

@openshift/sig-auth

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 1, 2019
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 1, 2019

/retest

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label May 1, 2019
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 1, 2019

previous was lgtmd

@deads2k deads2k mentioned this pull request May 1, 2019
Merged
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 1, 2019

/hold

waiting on openshift/cluster-monitoring-operator#343

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2019
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 2, 2019

/retest

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 2, 2019

This is the same as the other lgtmd one

@deads2k deads2k removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2019
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 2, 2019

/retest

for images

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 2, 2019
@squeed squeed mentioned this pull request May 2, 2019
Closed
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 2, 2019
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 2, 2019

/retest

1 similar comment
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 2, 2019

/retest

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 2, 2019

infra appears to be flaking hard

/retest

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 2, 2019

/retest

1 similar comment
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 2, 2019

/retest

@sallyom
Copy link
Copy Markdown
Contributor

sallyom commented May 2, 2019

this will follow

@sallyom
Copy link
Copy Markdown
Contributor

sallyom commented May 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enj enj mentioned this pull request May 2, 2019
Closed
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 2, 2019

/retest

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 2, 2019

Upgrade worked https://storage.googleapis.com/origin-ci-test/pr-logs/pull/22737/pull-ci-openshift-origin-master-e2e-aws-upgrade/432/artifacts/e2e-aws-upgrade/must-gather/cluster-scoped-resources/config.openshift.io/clusterversions.yaml, but flaked on flaky test https://search.svc.ci.openshift.org/?search=replicaset+%22rs%22+never+became+ready&maxAge=168h&context=2&type=all

Merging to free up followups in parallel.

@deads2k deads2k merged commit 85f1906 into openshift:master May 2, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 2, 2019

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade b8af4f2 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@sallyom sallyom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deads2k @sallyom @openshift-ci-robot