Skip to content

Add clusteroperators and clusterversions to explain tests#22748

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
soltysh:e2e_explain_followup
May 3, 2019
Merged

Add clusteroperators and clusterversions to explain tests#22748
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
soltysh:e2e_explain_followup

Conversation

@soltysh
Copy link
Copy Markdown
Contributor

@soltysh soltysh commented May 2, 2019

This is a followup from #22696 now that openshift/cluster-version-operator#168 merged
/assign @mfojtik

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 2, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2019
@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented May 3, 2019

/retest

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented May 3, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

// {Group: "machineconfiguration.openshift.io", Version: "v1", Resource: "controllerconfigs"},
// {Group: "machineconfiguration.openshift.io", Version: "v1", Resource: "kubeletconfigs"},
// {Group: "machineconfiguration.openshift.io", Version: "v1", Resource: "machineconfigpools"},
// {Group: "machineconfiguration.openshift.io", Version: "v1", Resource: "machineconfigs"},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how we can move this type to openshift/api. machineconfigs depends on Ignition which we don't control so we can't add tags for autogenerated stuff. We're moving what we can from above in openshift/api#301 but there's something which we need to understand and fix yet

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@runcom not everything needs to be in openshift/api to get it tested. The gist is to publish those information when creating those CRDs.

@ingvagabund
Copy link
Copy Markdown
Member

ingvagabund commented May 3, 2019

Is

$ oc explain clusteroperators
KIND:     ClusterOperator
VERSION:  config.openshift.io/v1

DESCRIPTION:

FIELDS:
   apiVersion	<string>
     APIVersion defines the versioned schema of this representation of an
     object. Servers should convert recognized schemas to the latest internal
     value, and may reject unrecognized values. More info:
     https://git.k8s.io/community/contributors/devel/api-conventions.md#resources

   kind	<string>
     Kind is a string value representing the REST resource this object
     represents. Servers may infer this from the endpoint the client submits
     requests to. Cannot be updated. In CamelCase. More info:
     https://git.k8s.io/community/contributors/devel/api-conventions.md#types-kinds

   metadata	<Object>
     Standard object's metadata. More info:
     https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata

   spec	<map[string]> -required-
     spec hold the intent of how this operator should behave.

   status	<Object>
     status holds the information about the state of an operator. It is
     consistent with status information across the kube ecosystem.

the expected output? No need to describe fields of spec/status fields?

@openshift-merge-robot openshift-merge-robot merged commit 4a950b0 into openshift:master May 3, 2019
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented May 7, 2019

@ingvagabund - yes, thanks!

@soltysh soltysh deleted the e2e_explain_followup branch May 7, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants