Add clusteroperators and clusterversions to explain tests#22748
Add clusteroperators and clusterversions to explain tests#22748openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| // {Group: "machineconfiguration.openshift.io", Version: "v1", Resource: "controllerconfigs"}, | ||
| // {Group: "machineconfiguration.openshift.io", Version: "v1", Resource: "kubeletconfigs"}, | ||
| // {Group: "machineconfiguration.openshift.io", Version: "v1", Resource: "machineconfigpools"}, | ||
| // {Group: "machineconfiguration.openshift.io", Version: "v1", Resource: "machineconfigs"}, |
There was a problem hiding this comment.
I'm not sure how we can move this type to openshift/api. machineconfigs depends on Ignition which we don't control so we can't add tags for autogenerated stuff. We're moving what we can from above in openshift/api#301 but there's something which we need to understand and fix yet
There was a problem hiding this comment.
@runcom not everything needs to be in openshift/api to get it tested. The gist is to publish those information when creating those CRDs.
|
Is the expected output? No need to describe fields of |
|
@ingvagabund - yes, thanks! |
This is a followup from #22696 now that openshift/cluster-version-operator#168 merged
/assign @mfojtik