Skip to content

add RBR from CRDs#22765

Merged
openshift-merge-robot merged 5 commits intoopenshift:masterfrom
deads2k:sally-rbr
May 4, 2019
Merged

add RBR from CRDs#22765
openshift-merge-robot merged 5 commits intoopenshift:masterfrom
deads2k:sally-rbr

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented May 3, 2019

/assign @sallyom

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 3, 2019
@openshift-ci-robot openshift-ci-robot requested review from csrwng and dcbw May 3, 2019 15:04
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 3, 2019

This will currently fail on

                restrictusers_test.go:95: unexpected error: RoleBindingRestriction.authorization.openshift.io "match-users-alice" is invalid: []: Invalid value: map[string]interface {}{"metadata":map[string]interface {}{"name":"match-users-alice", "namespace":"namespace", "creationTimestamp":"2019-05-03T15:00:12Z", "generation":1, "uid":"26c40c78-6db4-11e9-926e-54e1ad486dd3"}, "spec":map[string]interface {}{"userrestriction":map[string]interface {}{"labels":interface {}(nil), "users":[]interface {}{"alice"}, "groups":interface {}(nil)}, "grouprestriction":interface {}(nil), "serviceaccountrestriction":interface {}(nil)}, "kind":"RoleBindingRestriction", "apiVersion":"authorization.openshift.io/v1"}: validation failure list:
                    spec.userrestriction.groups in body must be of type array: "null"
                    spec.userrestriction.labels in body must be of type array: "null"

roleBindingRestrictionStorage, err := rolebindingrestrictionetcd.NewREST()
if err != nil {
return nil, fmt.Errorf("error building REST storage: %v", err)
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll clean this up, my bad, can be done in follow-up if necessary

@sallyom
Copy link
Copy Markdown
Contributor

sallyom commented May 3, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k mentioned this pull request May 3, 2019
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 3, 2019

/retest

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 3, 2019

/test all

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 4, 2019

/retest

1 similar comment
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 4, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit a0a3b1f into openshift:master May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants