Skip to content

Cluster Loader: Add switch to handle yaml as podspec in config#22870

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sjug:cl_yaml_spec
May 22, 2019
Merged

Cluster Loader: Add switch to handle yaml as podspec in config#22870
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sjug:cl_yaml_spec

Conversation

@sjug
Copy link
Copy Markdown
Contributor

@sjug sjug commented May 20, 2019

$title

@sjug sjug requested a review from jmencak May 20, 2019 12:53
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2019
@openshift-ci-robot openshift-ci-robot requested a review from enj May 20, 2019 12:54
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2019
@sjug sjug changed the title Add switch to handle yaml as podspec in config Cluster Loader: Add switch to handle yaml as podspec in config May 20, 2019
@jmencak
Copy link
Copy Markdown
Contributor

jmencak commented May 20, 2019

Good idea, yaml support is a must.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 20, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@sjug
Copy link
Copy Markdown
Contributor Author

sjug commented May 21, 2019

/test e2e-aws-upgrade

1 similar comment
@sjug
Copy link
Copy Markdown
Contributor Author

sjug commented May 21, 2019

/test e2e-aws-upgrade

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@sjug
Copy link
Copy Markdown
Contributor Author

sjug commented May 21, 2019

/test e2e-aws-upgrade

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d2aebcc into openshift:master May 22, 2019
@sjug sjug deleted the cl_yaml_spec branch May 22, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmencak jmencak Awaiting requested review from jmencak

@enj enj Awaiting requested review from enj

Assignees

@jmencak jmencak

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sjug @jmencak @openshift-ci-robot @openshift-bot @openshift-merge-robot