Bug 1712637: use fallback when must-gather imagestream not available

[sanchezl]

The fallback image was only being used if the must-gather imagestream was available, but did not resolve.

[tnozicka]

I don't think hard coding a registry will play well in the future. (different registries, disconnected envs)

Also a fallback to latest might mean several releases of skew.

I would hope this finds the image like oc adm release info registry.svc.ci.openshift.org/ocp/release:4.1.0-0.ci-2019-05-16-111356 --image-for=must-gatheror take it as a flag.

[deads2k]

nit: project style excludes the else

[deads2k]

I would hope this finds the image like oc adm release info registry.svc.ci.openshift.org/ocp/release:4.1.0-0.ci-2019-05-16-111356 --image-for=must-gatheror take it as a flag.

It does if someone really wants to. This is a good attempt at "do what the user wants even on very dead clusters."

/lgtm
/hold

hold for nit, self-tag after.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/oc/OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[mfojtik]

/cherrypick release-4.1

For https://bugzilla.redhat.com/show_bug.cgi?id=1712637 (it is 4.1 BZ)

[openshift-cherrypick-robot]

@mfojtik: new pull request created: #23001

Details

In response to this:

/cherrypick release-4.1

For https://bugzilla.redhat.com/show_bug.cgi?id=1712637 (it is 4.1 BZ)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.