Skip to content

Bug 1755039: Enable storage tests that require 1.16 kubelet#23894

Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
jsafrane:enable-1.16-tests
Oct 8, 2019
Merged

Bug 1755039: Enable storage tests that require 1.16 kubelet#23894
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
jsafrane:enable-1.16-tests

Conversation

@jsafrane
Copy link
Copy Markdown
Contributor

@jsafrane jsafrane commented Oct 2, 2019

+ remove one unused pattern
+ reshuffle remaining disabled storage tests a bit and add BZ link to one
(see the individual commits)

@openshift/storage

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 2, 2019
@openshift-ci-robot
Copy link
Copy Markdown

@jsafrane: This pull request references Bugzilla bug 1755039, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1755039: Enable storage tests that require 1.16 kubelet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 2, 2019
@jsafrane
Copy link
Copy Markdown
Contributor Author

jsafrane commented Oct 2, 2019

/retest

2 similar comments
@jsafrane
Copy link
Copy Markdown
Contributor Author

jsafrane commented Oct 2, 2019

/retest

@jsafrane
Copy link
Copy Markdown
Contributor Author

jsafrane commented Oct 3, 2019

/retest

1.16 kubelet has hit RHCOS.

In addition, link disabled storage test to BZ.
The pattern does not match any test.
@jsafrane
Copy link
Copy Markdown
Contributor Author

jsafrane commented Oct 3, 2019

/retest

@bertinatto
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2019
@bertinatto
Copy link
Copy Markdown
Member

bertinatto commented Oct 4, 2019

/assign @mfojtik
for approval

Edit: sorry, Maciej isn't in the OWNERS

@bertinatto
Copy link
Copy Markdown
Member

/assign @knobunc

@knobunc
Copy link
Copy Markdown
Contributor

knobunc commented Oct 7, 2019

/approve

Thanks!

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit da63d7b into openshift:master Oct 8, 2019
@openshift-ci-robot
Copy link
Copy Markdown

@jsafrane: All pull requests linked via external trackers have merged. Bugzilla bug 1755039 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1755039: Enable storage tests that require 1.16 kubelet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants