[WIP] Bug 1882853: Add cluster proxy settings to url tester exutil by sgreene570 · Pull Request #25577 · openshift/origin

sgreene570 · 2020-10-01T17:13:23Z

This PR is an attempt to resolve https://bugzilla.redhat.com/show_bug.cgi?id=1882853 by having the url tester util in test/extended/util/url/url.go apply available cluster proxy settings to the url tester execpod. Tests that utilize cluster ingress from within the cluster and utilize the url tester util can pass a proxy host to the Tester struct via the new WithProxy function.

This PR adds a helper function to get the cluster proxy config to the new test/extended/util/proxy.go file.

openshift/release#12375 will allow this PR to be verified on the e2e-aws-proxy job.

openshift-ci-robot · 2020-10-01T17:13:27Z

@sgreene570: This pull request references Bugzilla bug 1882853, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[WIP] Bug 1882853: Add cluster proxy settings to url tester exutil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-01T17:13:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sgreene570
To complete the pull request process, please assign adambkaplan after the PR has been reviewed.
You can assign the PR to them by writing /assign @adambkaplan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

test/extended/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sgreene570 · 2020-10-02T13:38:27Z

/bugzilla refresh

openshift-ci-robot · 2020-10-02T13:38:30Z

@sgreene570: This pull request references Bugzilla bug 1882853, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 · 2020-10-06T13:46:26Z

/bugzilla refresh

openshift-ci-robot · 2020-10-06T13:46:34Z

@sgreene570: This pull request references Bugzilla bug 1882853, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 · 2020-10-06T16:38:48Z

/test e2e-aws-proxy

sgreene570 · 2020-10-06T18:03:22Z

/test e2e-aws-proxy

openshift-ci-robot · 2020-10-06T19:13:52Z

@sgreene570: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-fips	`4b5dd57`	link	`/test e2e-aws-fips`
ci/prow/e2e-aws-proxy	`4b5dd57`	link	`/test e2e-aws-proxy`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sgreene570 · 2020-10-08T20:28:04Z

Proxy CI isnt feeling so well right now for unrelated reasons 🤒
Ill revisit this fixup once its back up and running.

https://coreos.slack.com/archives/CLJSH16J0/p1602173648085800

sgreene570 · 2020-11-10T17:58:48Z

/test e2e-aws-proxy

sgreene570 · 2020-11-10T20:07:15Z

/test e2e-aws-proxy

openshift-merge-robot · 2020-11-10T22:11:47Z

@sgreene570: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-upgrade	`4658821`	link	`/test e2e-gcp-upgrade`
ci/prow/e2e-gcp	`4658821`	link	`/test e2e-gcp`
ci/prow/e2e-gcp-builds	`4658821`	link	`/test e2e-gcp-builds`
ci/prow/e2e-agnostic-cmd	`4658821`	link	`/test e2e-agnostic-cmd`
ci/prow/e2e-aws-fips	`4658821`	link	`/test e2e-aws-fips`
ci/prow/e2e-aws-serial	`4658821`	link	`/test e2e-aws-serial`
ci/prow/e2e-aws-proxy	`4658821`	link	`/test e2e-aws-proxy`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sgreene570 · 2020-11-11T18:26:30Z

Doesn't fix the tests I thought it would
/close

openshift-ci-robot · 2020-11-11T18:26:47Z

@sgreene570: Closed this PR.

Details

In response to this:

Doesn't fix the tests I thought it would
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-11-11T18:26:52Z

@sgreene570: This pull request references Bugzilla bug 1882853. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

[WIP] Bug 1882853: Add cluster proxy settings to url tester exutil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Add a simple proxy util for fetching the cluster's egress proxy config.

Add's env vars to the url tester's execpod in test/extended/util/url/url.go so that the url tester can respect cluster-wide proxy settings during e2e tests.

Set the url tester to respect the cluster-wide proxy in test/extended/router/router.go.

Set the url tester to respect the cluster-wide proxy in test/extended/operators/routable.go

sgreene570 · 2021-02-10T21:23:27Z

/reopen

openshift-ci-robot · 2021-02-10T21:23:38Z

@sgreene570: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-02-10T21:23:41Z

@sgreene570: This pull request references Bugzilla bug 1882853, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[WIP] Bug 1882853: Add cluster proxy settings to url tester exutil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 · 2021-02-10T21:25:45Z

might have missed something, testing my hunch out. Execpods for the url tester get re-used, so a test might have been creating the pod without the proxy env vars before tests that needed it even had the chance

/test e2e-aws-proxy

openshift-ci · 2021-02-10T23:26:40Z

@sgreene570: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-agnostic-cmd	`df991d0`	link	`/test e2e-agnostic-cmd`
ci/prow/e2e-aws-serial	`df991d0`	link	`/test e2e-aws-serial`
ci/prow/e2e-aws-proxy	`df991d0`	link	`/test e2e-aws-proxy`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sgreene570 · 2021-02-11T14:35:00Z

I think the issue might be DNS resolution of the ELB

/close

openshift-ci-robot · 2021-02-11T14:35:13Z

@sgreene570: Closed this PR.

Details

In response to this:

I think the issue might be DNS resolution of the ELB

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from adambkaplan and ironcladlou October 1, 2020 17:13

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 6, 2020

sgreene570 force-pushed the bz-1882853 branch from 4b5dd57 to 4658821 Compare November 10, 2020 17:55

openshift-ci-robot closed this Nov 11, 2020

sgreene570 added 5 commits February 10, 2021 15:30

exutil: Add GetClusterProxyConfig() helper

5d3da34

Add a simple proxy util for fetching the cluster's egress proxy config.

exutil: Add proxy config env vars to url tester

3679df0

Add's env vars to the url tester's execpod in test/extended/util/url/url.go so that the url tester can respect cluster-wide proxy settings during e2e tests.

router: Add proxy url to url tester

098c7e1

Set the url tester to respect the cluster-wide proxy in test/extended/router/router.go.

operators: Add proxy url to url tester

4d7b919

Set the url tester to respect the cluster-wide proxy in test/extended/operators/routable.go

Pass proxy to all testers. WIP

df991d0

openshift-ci-robot reopened this Feb 10, 2021

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 10, 2021

sgreene570 force-pushed the bz-1882853 branch from 4658821 to df991d0 Compare February 10, 2021 21:23

openshift-ci-robot closed this Feb 11, 2021

Conversation

sgreene570 commented Oct 1, 2020

Uh oh!

openshift-ci-robot commented Oct 1, 2020

Uh oh!

openshift-ci-robot commented Oct 1, 2020

Uh oh!

sgreene570 commented Oct 2, 2020

Uh oh!

openshift-ci-robot commented Oct 2, 2020

Uh oh!

sgreene570 commented Oct 6, 2020

Uh oh!

openshift-ci-robot commented Oct 6, 2020

Uh oh!

sgreene570 commented Oct 6, 2020

Uh oh!

sgreene570 commented Oct 6, 2020

Uh oh!

openshift-ci-robot commented Oct 6, 2020

Uh oh!

sgreene570 commented Oct 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sgreene570 commented Nov 10, 2020

Uh oh!

sgreene570 commented Nov 10, 2020

Uh oh!

openshift-merge-robot commented Nov 10, 2020

Uh oh!

sgreene570 commented Nov 11, 2020

Uh oh!

openshift-ci-robot commented Nov 11, 2020

Uh oh!

openshift-ci-robot commented Nov 11, 2020

Uh oh!

sgreene570 commented Feb 10, 2021

Uh oh!

openshift-ci-robot commented Feb 10, 2021

Uh oh!

openshift-ci-robot commented Feb 10, 2021

Uh oh!

sgreene570 commented Feb 10, 2021

Uh oh!

openshift-ci Bot commented Feb 10, 2021

Uh oh!

sgreene570 commented Feb 11, 2021

Uh oh!

openshift-ci-robot commented Feb 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sgreene570 commented Oct 8, 2020 •

edited

Loading