Skip to content

jenkins: do not pull templates from master#26272

Closed
yselkowitz wants to merge 1 commit intoopenshift:release-4.8from
yselkowitz:jenkins-4.8
Closed

jenkins: do not pull templates from master#26272
yselkowitz wants to merge 1 commit intoopenshift:release-4.8from
yselkowitz:jenkins-4.8

Conversation

@yselkowitz
Copy link
Contributor

Changes from development in master should not be pulled automatically
into stable branches.

/cc @gabemontero @akram

Changes from development in master should not be pulled automatically
into stable branches.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@yselkowitz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

jenkins: do not pull templates from master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from akram and gabemontero June 25, 2021 20:30
@yselkowitz
Copy link
Contributor Author

Background in #26268 (comment)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yselkowitz
To complete the pull request process, please assign knobunc after the PR has been reviewed.
You can assign the PR to them by writing /assign @knobunc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Contributor

Yeah your change here is not going to fix https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_kubernetes/829/pull-ci-openshift-kubernetes-release-4.8-e2e-aws-jenkins/1408481494824914944

You want to make the same change in 4.8 as we made in master branch at https://github.com/openshift/origin/blob/master/test/extended/builds/pipeline_origin_bld.go#L268

For that, we'll need a bugzilla

Now, with the file you did change, I would also just comment that test out in the same way with this PR. That will help the multi arch runs I worked with Jeremy and folks last year or 2019 whenever it was, where we don't use centos based images.

@gabemontero
Copy link
Contributor

Yeah your change here is not going to fix https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_kubernetes/829/pull-ci-openshift-kubernetes-release-4.8-e2e-aws-jenkins/1408481494824914944

You want to make the same change in 4.8 as we made in master branch at https://github.com/openshift/origin/blob/master/test/extended/builds/pipeline_origin_bld.go#L268

I can take on ^^

For that, we'll need a bugzilla

Now, with the file you did change, I would also just comment that test out in the same way with this PR. That will help the multi arch runs I worked with Jeremy and folks last year or 2019 whenever it was, where we don't use centos based images.

@gabemontero
Copy link
Contributor

So bottom line, use this PR to comment out the offending client plugin test in the rhel only jenkins pipeline file, and I'll work on the backport of that to 4.8, etc.

@gabemontero
Copy link
Contributor

#26275 is up @yselkowitz

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2021

@yselkowitz: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips e985779 link /test e2e-aws-fips
ci/prow/e2e-aws e985779 link /test e2e-aws
ci/prow/e2e-gcp e985779 link /test e2e-gcp
ci/prow/e2e-aws-serial e985779 link /test e2e-aws-serial
ci/prow/e2e-metal-ipi-virtualmedia e985779 link /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-aws-proxy e985779 link /test e2e-aws-proxy
ci/prow/e2e-metal-ipi-ovn-ipv6 e985779 link /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-ovn-dualstack e985779 link /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-upgrade e985779 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yselkowitz
Copy link
Contributor Author

So bottom line, use this PR to comment out the offending client plugin test in the rhel only jenkins pipeline file, and I'll work on the backport of that to 4.8, etc.

Filed #26278 in place of this.

@yselkowitz yselkowitz closed this Jun 28, 2021
@yselkowitz yselkowitz deleted the jenkins-4.8 branch October 5, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants