[4.12] Unrevert rebase with ginkgo test init duplication removed #27507
Conversation
|
@bparees: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bparees The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bparees: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/payload 4.12 nightly blocking |
|
@stbenjam: trigger 6 job(s) of type blocking for the nightly release of OCP 4.12
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3cec5050-5a10-11ed-8063-d7cb8c9f20cc-0 trigger 4 job(s) of type blocking for the ci release of OCP 4.12
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3cec5050-5a10-11ed-8063-d7cb8c9f20cc-1 |
|
@bparees: trigger 4 job(s) of type blocking for the ci release of OCP 4.12
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bbc9bb10-5a10-11ed-9a21-053186dba943-0 |
|
@bparees: trigger 4 job(s) of type blocking for the ci release of OCP 4.12
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c1114b9c-5a10-11ed-9118-836f6049fbbb-0 |
|
/payload 4.12 nightly blocking |
|
@bparees: trigger 6 job(s) of type blocking for the nightly release of OCP 4.12
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0a741660-5a35-11ed-8c5a-9e4c00c62f56-0 trigger 4 job(s) of type blocking for the ci release of OCP 4.12
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0a741660-5a35-11ed-8c5a-9e4c00c62f56-1 |
|
/retest |
| // could be running at the same time. While these are technically [Serial], ginkgo | ||
| // parallel mode provides this guarantee. Doing this for all suites would be too | ||
| // slow. | ||
| setTestExclusion(tests, func(suitePath string, t *testCase) bool { |
There was a problem hiding this comment.
where did this move and if straight removed, how did you determine this was now safe?
There was a problem hiding this comment.
@soltysh ? From what I can tell I didn't have this dropped in my ginkgo v2 rebase
There was a problem hiding this comment.
preserving the answer from slack: 86e70b2
|
seems to have an issue on verify-deps: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27507/pull-ci-openshift-origin-release-4.12-verify-deps/1587576646750179328 /payload 4.12 nightly blocking |
|
@kikisdeliveryservice: trigger 6 job(s) of type blocking for the nightly release of OCP 4.12
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6283be50-5bb6-11ed-9ba7-5c4fe8bf6f7b-0 |
the deps issue is because this PR is carrying a patch to ginkgo. The commit really needs to go into openshift/onsi-gingko and then get vendored here. I assume we'll do that once we're confident of all the changes we need. |
|
being pursued in #27526 (4.13, but will be backported). |
4 participants
No description provided.