Skip to content

Apply microshift patches to origin #28653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stbenjam wants to merge 1 commit into from
Closed

Apply microshift patches to origin #28653

stbenjam wants to merge 1 commit into from

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Mar 12, 2024 •
edited
Loading

@stbenjam @pacevedom
Apply microshift patches to origin
45f9b75 
From:
  https://github.com/openshift/microshift/tree/main/origin/patches

Co-authored-by: Pablo Acevedo Montserrat <pacevedo@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024
@openshift-ci openshift-ci bot requested review from bparees and jmguzik March 12, 2024 18:07
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-upgrade 45f9b75 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-sdn 45f9b75 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-metal-ipi-ovn-ipv6 45f9b75 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn-rt-upgrade 45f9b75 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade 45f9b75 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 45f9b75 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam stbenjam changed the title [wip] Apply microshift patches to origin Apply microshift patches to origin Mar 13, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2024
stbenjam
stbenjam commented Mar 13, 2024
View reviewed changes
test/extended/router/scoped.go
o.Expect(err).NotTo(o.HaveOccurred())

execPod := exutil.CreateExecPodOrFail(oc.AdminKubeClient(), ns, "execpod")
execPod := exutil.CreateAgnhostPodOrFail(oc.AdminKubeClient(), ns, "execpod")
Copy link
Member Author

@stbenjam stbenjam Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are the only controversial changes, IIUC the ShellImage doesn't work on microshift because there's no image registry in the cluster, and that's where the tools image comes from

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 12, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 12, 2024
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 12, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 12, 2024
@stbenjam stbenjam closed this Jul 16, 2024
@stbenjam stbenjam deleted the microshift branch July 16, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@jmguzik jmguzik Awaiting requested review from jmguzik

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stbenjam @openshift-bot