OCPBUGS-39363: Reenable Rails tests and update the sample repos test to support deployments by metlos · Pull Request #29097 · openshift/origin

metlos · 2024-09-12T09:39:12Z

After a change of decision about the support for Rails, we need to reenable it in the Samples Operator and therefore also in the integration tests here.

In addition to re-enabling the dedicated ruby test, we also need to support this in the samples_repo tests. Because the rails template now uses Deployments instead of DeploymentConfigs, it was also needed to add support for that in the tests.

openshift-ci-robot · 2024-09-12T09:39:17Z

@metlos: This pull request references Jira Issue OCPBUGS-39363, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

After a change of decision about the support for Rails, we need to reenable it in the Samples Operator and therefore also in the integration tests here.

In addition to re-enabling the dedicated ruby test, we also need to support this in the samples_repo tests. Because the rails template now uses Deployments instead of DeploymentConfigs, it was also needed to add support for that in the tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

metlos · 2024-09-12T09:39:39Z

/jira refresh

openshift-ci-robot · 2024-09-12T09:39:43Z

@metlos: This pull request references Jira Issue OCPBUGS-39363, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jitendar-singh

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

metlos · 2024-09-12T09:40:23Z

/test e2e-gcp-ovn-image-ecosystem

ausil · 2024-09-12T13:02:04Z

/lgtm

metlos · 2024-09-12T17:45:29Z

Note that the e2e-gcp-ovn-image-ecosystem test should fail because of a problem in perl template (addressed #29096) but the tests for Rails should both pass.

metlos · 2024-09-12T18:34:53Z

/retest

openshift-trt-bot · 2024-09-12T23:55:19Z

Job Failure Risk Analysis for sha: 1b0b8c3

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade	IncompleteTests Tests for this run (191) are below the historical average (739): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade	IncompleteTests Tests for this run (1132) are below the historical average (2232): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-serial	IncompleteTests Tests for this run (102) are below the historical average (774): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

metlos · 2024-09-13T18:07:38Z

/retest

metlos · 2024-09-16T07:58:30Z

/retest

openshift-trt-bot · 2024-09-16T12:41:46Z

Job Failure Risk Analysis for sha: bbb5fa8

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade	High [bz-kube-apiserver][invariant] alert/KubeAPIErrorBudgetBurn should not be at or above info This test has passed 99.44% of 6995 runs on release 4.18 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial	High [sig-arch] events should not repeat pathologically for ns/openshift-ovn-kubernetes This test has passed 100.00% of 53 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days. --- [bz-Management Console] clusteroperator/console should not change condition/Available This test has passed 100.00% of 53 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days. Open Bugs clusteroperator/console: unexpected state transitions during e2e test run --- [sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers for ns/openshift-multus This test has passed 100.00% of 53 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days.

metlos · 2024-09-16T20:31:09Z

/retest

fbm3307 · 2024-09-18T06:26:48Z

/lgtm

metlos · 2024-09-18T07:20:06Z

/retest

metlos · 2024-09-18T07:21:15Z

/assign @DennisPeriquet

metlos · 2024-09-18T12:29:37Z

/test e2e-gcp-ovn-image-ecosystem

openshift-trt-bot · 2024-09-18T15:52:09Z

Job Failure Risk Analysis for sha: 6dd82a2

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade	Medium [sig-api-machinery] disruption/openshift-api connection/reused should be available throughout the test This test has passed 97.10% of 5455 runs on release 4.18 [Overall] in the last week. --- [sig-api-machinery] disruption/kube-api connection/new should be available throughout the test This test has passed 88.38% of 198 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week. --- [sig-api-machinery] disruption/openshift-api connection/new should be available throughout the test This test has passed 97.47% of 198 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week. --- [sig-api-machinery] disruption/oauth-api connection/reused should be available throughout the test This test has passed 92.42% of 198 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week. --- Showing 4 of 6 test results
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial	Medium [sig-node] static pods should start after being created This test has passed 94.64% of 56 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-single-node-serial'] in the last 14 days. Open Bugs Static pod controller pods sometimes fail to start

Deployments instead of DeploymentConfigs. This should enable us using either the old templates in 4.16 stream that use DeploymentConfigs and the new templates in 4.17+ that use Deployments.

ausil · 2024-09-18T18:04:27Z

/lgtm

openshift-ci · 2024-09-18T18:04:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ausil, fbm3307, metlos
Once this PR has been reviewed and has the lgtm label, please ask for approval from dennisperiquet. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-09-18T20:08:06Z

@metlos: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-ovn-cmd	`212968f`	link	false	`/test e2e-agnostic-ovn-cmd`
ci/prow/e2e-aws-ovn-single-node-upgrade	`212968f`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-aws-ovn-upgrade	`212968f`	link	false	`/test e2e-aws-ovn-upgrade`
ci/prow/e2e-aws-ovn-ipsec-serial	`212968f`	link	false	`/test e2e-aws-ovn-ipsec-serial`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-trt-bot · 2024-09-18T20:44:34Z

Job Failure Risk Analysis for sha: 212968f

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade	Medium [sig-api-machinery] disruption/kube-api connection/reused should be available throughout the test This test has passed 87.70% of 187 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week. --- [sig-api-machinery] disruption/oauth-api connection/reused should be available throughout the test This test has passed 91.98% of 187 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week. --- [sig-api-machinery] disruption/kube-api connection/new should be available throughout the test This test has passed 87.70% of 187 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week. --- [sig-api-machinery] disruption/oauth-api connection/new should be available throughout the test This test has passed 91.98% of 187 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.

metlos · 2024-09-19T09:46:08Z

I'm closing this in favor of #29116.

openshift-ci-robot · 2024-09-19T09:46:11Z

@metlos: This pull request references Jira Issue OCPBUGS-39363. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

After a change of decision about the support for Rails, we need to reenable it in the Samples Operator and therefore also in the integration tests here.

In addition to re-enabling the dedicated ruby test, we also need to support this in the samples_repo tests. Because the rails template now uses Deployments instead of DeploymentConfigs, it was also needed to add support for that in the tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 12, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 12, 2024

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 12, 2024

openshift-ci Bot requested a review from jitendar-singh September 12, 2024 09:39

openshift-ci Bot requested review from coreydaley and p0lyn0mial September 12, 2024 09:41

openshift-ci Bot assigned ausil Sep 12, 2024

openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Sep 12, 2024

openshift-ci Bot assigned fbm3307 Sep 18, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024

openshift-ci Bot assigned DennisPeriquet Sep 18, 2024

Re-enable the s2i rails test and update it to also support samples with

212968f

Deployments instead of DeploymentConfigs. This should enable us using either the old templates in 4.16 stream that use DeploymentConfigs and the new templates in 4.17+ that use Deployments.

metlos force-pushed the reenable-rails-and-support-deployment branch from 6dd82a2 to 212968f Compare September 18, 2024 16:31

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024

metlos mentioned this pull request Sep 19, 2024

OCPBUGS-42191: Fix image ecosystem tests #29116

Merged

metlos closed this Sep 19, 2024

Conversation

metlos commented Sep 12, 2024

Uh oh!

openshift-ci-robot commented Sep 12, 2024

Uh oh!

metlos commented Sep 12, 2024

Uh oh!

openshift-ci-robot commented Sep 12, 2024

Uh oh!

metlos commented Sep 12, 2024

Uh oh!

ausil commented Sep 12, 2024

Uh oh!

metlos commented Sep 12, 2024

Uh oh!

metlos commented Sep 12, 2024

Uh oh!

openshift-trt-bot commented Sep 12, 2024

Uh oh!

metlos commented Sep 13, 2024

Uh oh!

metlos commented Sep 16, 2024

Uh oh!

openshift-trt-bot commented Sep 16, 2024

Uh oh!

metlos commented Sep 16, 2024

Uh oh!

fbm3307 commented Sep 18, 2024

Uh oh!

metlos commented Sep 18, 2024

Uh oh!

metlos commented Sep 18, 2024

Uh oh!

metlos commented Sep 18, 2024

Uh oh!

openshift-trt-bot commented Sep 18, 2024

Uh oh!

ausil commented Sep 18, 2024

Uh oh!

openshift-ci Bot commented Sep 18, 2024

Uh oh!

openshift-ci Bot commented Sep 18, 2024

Uh oh!

openshift-trt-bot commented Sep 18, 2024

Uh oh!

metlos commented Sep 19, 2024

Uh oh!

openshift-ci-robot commented Sep 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants