Skip to content

NO-ISSUE: Add Capability and FeatureGate checks to OLMv1 tests #29283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmshort wants to merge 3 commits into from
Closed

NO-ISSUE: Add Capability and FeatureGate checks to OLMv1 tests #29283

tmshort wants to merge 3 commits into from

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Nov 11, 2024 •
edited
Loading

This required:

go get github.com/openshift/api@a2817b89f7e0989016967055a142d5e88bed18de
go get github.com/openshift/client-go@923091dd2b1a3d6fe75a06cc4f45972a3ddf84c2
go get github.com/openshift/library-go@0064ad7bd060b9fd52f7840972c1d3e72186d0f0
// update the replaces of k8s.io/kubernetes to github.com/openshift/kubernetes@v1.30.1-0.20241111135607a3f31a4f2c58 
go mod tidy
go mod vendor

/hold until capability is fully implemented

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 11, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Nov 11, 2024
@tmshort
Copy link
Contributor Author

tmshort commented Nov 11, 2024

/test all

@tmshort tmshort force-pushed the add-olmv1-capability branch from 9717d62 to b635ba3 Compare November 11, 2024 20:59
@tmshort tmshort marked this pull request as ready for review November 11, 2024 21:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2024
@tmshort tmshort force-pushed the add-olmv1-capability branch from b635ba3 to 0c977aa Compare November 12, 2024 14:23
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tmshort
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the e2e-images-update Related to images used by e2e tests label Nov 12, 2024
@tmshort tmshort changed the title Add Capability check to OLMv1 tests NO-ISSUE: Add Capability check to OLMv1 tests Nov 12, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 12, 2024

@tmshort: This pull request explicitly references no jira issue.

Details

In response to this:

This required:

go get github.com/openshift/api@a2817b89f7e0989016967055a142d5e88bed18de
go get github.com/openshift/client-go@923091dd2b1a3d6fe75a06cc4f45972a3ddf84c2
go get github.com/openshift/library-go@0064ad7bd060b9fd52f7840972c1d3e72186d0f0
// update the replaces of k8s.io/kubernetes to github.com/openshift/kubernetes@v1.30.1-0.20241111135607a3f31a4f2c58 
go mod tidy
go mod vendor

/hold until capability is fully implemented

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Contributor Author

tmshort commented Nov 12, 2024

/retest

@tmshort tmshort mentioned this pull request Nov 12, 2024
Merged
@tmshort
Copy link
Contributor Author

tmshort commented Nov 12, 2024

/retest

wking
wking reviewed Nov 12, 2024
View reviewed changes
test/extended/olm/olmv1.go Outdated
})

func checkTestSkip(ctx context.Context, oc *exutil.CLI) {
if !exutil.IsTechPreviewNoUpgrade(ctx, oc.AdminConfigClient()) {
Copy link
Member

@wking wking Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way for tests to check the NewOLM feature gate, so you have one less thing you need to bump when that is added to the default feature set? This line hard-codes the current state, where the NewOLM feature gate is in tech-preview, but not yet in the default feature set.

Copy link
Contributor Author

@tmshort tmshort Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I think...

Copy link
Contributor Author

@tmshort tmshort Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get rid of the TechPreview check yet, because I wasn't sure of the status of the FeatureGate.

@tmshort
Update to latest openshift/api
60b3c40 
This required:

go get github.com/openshift/api@a2817b89f7e0989016967055a142d5e88bed18de
go get github.com/openshift/client-go@923091dd2b1a3d6fe75a06cc4f45972a3ddf84c2
go get github.com/openshift/library-go@0064ad7bd060b9fd52f7840972c1d3e72186d0f0
// update the replaces of k8s.io/kubernetes to github.com/openshift/kubernetes@v1.30.1-0.20241111135607-a3f31a4f2c58
go mod tidy
go mod vendor

Signed-off-by: Todd Short <todd.short@me.com>
@tmshort tmshort force-pushed the add-olmv1-capability branch from 0c977aa to 8bc0bc2 Compare November 12, 2024 21:15
@tmshort
Add Capability and FeatureGate check to OLMv1 tests
4b1a1fc 
Signed-off-by: Todd Short <todd.short@me.com>
@tmshort tmshort force-pushed the add-olmv1-capability branch from 8bc0bc2 to 4b1a1fc Compare November 12, 2024 21:33
@tmshort tmshort changed the title NO-ISSUE: Add Capability check to OLMv1 tests NO-ISSUE: Add Capability and FeatureGate checks to OLMv1 tests Nov 12, 2024
@tmshort
Remove OLMv1 TechPreview check in favor of feature gate
adac1cd 
Signed-off-by: Todd Short <todd.short@me.com>
@wking wking mentioned this pull request Nov 12, 2024
Merged
@tmshort
Copy link
Contributor Author

tmshort commented Nov 13, 2024

/retest

1 similar comment
@tmshort
Copy link
Contributor Author

tmshort commented Nov 13, 2024

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

@tmshort: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout adac1cd link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-gcp-ovn adac1cd link true /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 adac1cd link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-single-node-serial adac1cd link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade adac1cd link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn adac1cd link false /test e2e-metal-ipi-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmshort tmshort mentioned this pull request Nov 13, 2024
Merged
@openshift-trt-bot
Copy link

openshift-trt-bot commented Nov 13, 2024

Job Failure Risk Analysis for sha: adac1cd

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout High
[sig-network] can collect pod-to-pod poller pod logs
This test has passed 100.00% of 11 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-kube-apiserver-rollout'] in the last 14 days.
---
[sig-arch][Late][Jira:"kube-apiserver"] collect certificate data [Suite:openshift/conformance/parallel]
This test has passed 100.00% of 11 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-kube-apiserver-rollout'] in the last 14 days.
---
[sig-network] can collect host-to-pod poller pod logs
This test has passed 100.00% of 11 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-kube-apiserver-rollout'] in the last 14 days.
---
[Jira:"Network / ovn-kubernetes"] monitor test pod-network-avalibility setup
This test has passed 100.00% of 11 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-kube-apiserver-rollout'] in the last 14 days.
---
Showing 4 of 6 test results
pull-ci-openshift-origin-master-e2e-gcp-ovn High
[sig-network-edge][Conformance][Area:Networking][Feature:Router] The HAProxy router should pass the gRPC interoperability tests [apigroup:route.openshift.io][apigroup:operator.openshift.io] [Suite:openshift/conformance/parallel/minimal]
This test has passed 100.00% of 33 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (101) are below the historical average (2704): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn IncompleteTests
Tests for this run (101) are below the historical average (2514): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@perdasilva perdasilva mentioned this pull request Nov 14, 2024
Closed
@tmshort tmshort closed this Nov 14, 2024
@tmshort
Copy link
Contributor Author

tmshort commented Nov 14, 2024

Closing in favor of #29290

@tmshort tmshort deleted the add-olmv1-capability branch January 23, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@sjenning sjenning Awaiting requested review from sjenning

1 more reviewer

@wking wking wking left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. e2e-images-update Related to images used by e2e tests jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmshort @openshift-ci-robot @openshift-trt-bot @wking