-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Allow test to tolerate running on minimal images #30695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
/hold |
|
Scheduling required tests: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jupierce, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c3f3f11 to
4cfc809
Compare
|
New changes are detected. LGTM label has been removed. |
minimal images provide microdnf instead of dnf/yum. ART attempts to insulate most images from this change by providing a thin wrapper around dnf/yum. However, microdnf fundamentally lacks some features. config-manager is an example that is currently unsupported. In the case of ubi minimal, it should not be necessary to use config-manager to install ubi repositories, so instead of assuming it is necessary, it is only attempted after an attempt to install skopeo fails. ART_DNF_WRAPPER_POLICY=skip is a subtle change which prevents the CI variant of cli image from trying to detect and install repositories suitable to provide access to RPMs not typically available to UBI.
4cfc809 to
21111ad
Compare
|
Scheduling required tests: |
|
/retest |
|
/unhold |
|
/retest |
|
@jupierce: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
minimal images provide microdnf instead of dnf/yum. ART attempts to insulate most images from this change by providing a thin wrapper around dnf/yum. However, microdnf fundamentally lacks some features.
config-manager is an example that is currently unsupported. In the case of ubi minimal, it should not be necessary to use config-manager to install ubi repositories, so instead of assuming it is necessary, it is only attempted after an attempt to install skopeo fails.
ART_DNF_WRAPPER_POLICY=skip is a subtle change which prevents the CI variant of cli image from trying to detect and install repositories suitable to provide access to RPMs not typically available to UBI.