Skip to content

Conversation

@xiuwang
Copy link
Contributor

@xiuwang xiuwang commented Jan 29, 2026

This commit fixes test hangs on pure Kubernetes/AKS HCP clusters by adding SCC API existence detection before waiting for SCC annotations.
Problem:

  • SetupProject() and setupNamespace() unconditionally wait for SCC
    annotations on all clusters
  • SCC is OpenShift-specific and doesn't exist on Kubernetes/AKS
  • Tests hang indefinitely waiting for annotations that never arrive
    Solution:
  • Use DoesApiResourceExist() to detect if SCC API is available
  • Only call WaitForNamespaceSCCAnnotations() on OpenShift clusters
  • Skip SCC wait on pure Kubernetes/AKS clusters
passed: (2m39s) 2026-01-29T08:30:29 "[sig-hypershift] Hypershift Author:xiuwang-HyperShiftMGMT-Critical-86974-Update serviceAccountSigningKey to a new custom secret [Serial]"

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2026

@xiuwang: This pull request references OCPQE-31524 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This commit fixes test hangs on pure Kubernetes/AKS HCP clusters by adding SCC API existence detection before waiting for SCC annotations.
Problem:

  • SetupProject() and setupNamespace() unconditionally wait for SCC
    annotations on all clusters
  • SCC is OpenShift-specific and doesn't exist on Kubernetes/AKS
  • Tests hang indefinitely waiting for annotations that never arrive
    Solution:
  • Use DoesApiResourceExist() to detect if SCC API is available
  • Only call WaitForNamespaceSCCAnnotations() on OpenShift clusters
  • Skip SCC wait on pure Kubernetes/AKS clusters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial January 29, 2026 07:19
@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2026

@xiuwang: This pull request references OCPQE-31524 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This commit fixes test hangs on pure Kubernetes/AKS HCP clusters by adding SCC API existence detection before waiting for SCC annotations.
Problem:

  • SetupProject() and setupNamespace() unconditionally wait for SCC
    annotations on all clusters
  • SCC is OpenShift-specific and doesn't exist on Kubernetes/AKS
  • Tests hang indefinitely waiting for annotations that never arrive
    Solution:
  • Use DoesApiResourceExist() to detect if SCC API is available
  • Only call WaitForNamespaceSCCAnnotations() on OpenShift clusters
  • Skip SCC wait on pure Kubernetes/AKS clusters
passed: (2m39s) 2026-01-29T08:30:29 "[sig-hypershift] Hypershift Author:xiuwang-HyperShiftMGMT-Critical-86974-Update serviceAccountSigningKey to a new custom secret [Serial]"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@heliubj18
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026
@xingxingxia
Copy link

/lgtm

@xiuwang
Copy link
Contributor Author

xiuwang commented Jan 30, 2026

/retest

@xiuwang
Copy link
Contributor Author

xiuwang commented Jan 30, 2026

/retest-required

@xiuwang
Copy link
Contributor Author

xiuwang commented Jan 30, 2026

@liangxia @pruan-rht Could you help approve this? Thanks

@xiuwang
Copy link
Contributor Author

xiuwang commented Jan 30, 2026

/assign @petr-muller
Could you approve this? Thanks

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heliubj18, liangxia, petr-muller, xingxingxia, xiuwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2026
@xiuwang
Copy link
Contributor Author

xiuwang commented Feb 2, 2026

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 2, 2026
@openshift-ci-robot
Copy link

@xiuwang: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e3f443a and 2 for PR HEAD e170650 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 2, 2026

@xiuwang: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2964662 into openshift:main Feb 2, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants