Skip to content

OCPEDGE-2381: Verify etc pod should start with oom_score_adj as system-node-critical #30867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kasturinarra wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −0
Open

OCPEDGE-2381: Verify etc pod should start with oom_score_adj as system-node-critical #30867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions test/extended/two_node/tnf_topology.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ import (
)

const ensurePodmanEtcdContainerIsRunning = "podman inspect --format '{{.State.Running}}' etcd"
const getEtcdOOMScoreAdj = "GETPID=$(podman inspect etcd --format '{{.State.Pid}}') && cat /proc/$GETPID/oom_score_adj"
const getPcsEtcdOOMDefault = "pcs resource describe ocf:heartbeat:podman-etcd"
const expectedOOMScoreAdj = "-997"

var _ = g.Describe("[sig-node][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing topology", func() {
defer g.GinkgoRecover()
Expand Down Expand Up @@ -133,4 +136,25 @@ var _ = g.Describe("[sig-etcd][apigroup:config.openshift.io][OCPFeatureGate:Dual
o.Expect(got).To(o.Equal("'true'"), fmt.Sprintf("expected a podman etcd container running on Node %s: got running %s", node.Name, got))
}
})

g.It("should have etcd OOM score adjustment set to -997 on each node", func() {
nodes, err := utils.GetNodes(oc, utils.LabelNodeRoleControlPlane)
o.Expect(err).To(o.BeNil(), "Expected to retrieve control plane nodes without error")
o.Expect(nodes.Items).To(o.HaveLen(2), "Expected to retrieve two control plane nodes for DualReplica topology")

g.By("Verifying pcs resource describes etcd with OOM default of -997")
firstNode := nodes.Items[0]
pcsOutput, err := exutil.DebugNodeRetryWithOptionsAndChroot(oc, firstNode.Name, "openshift-etcd", "bash", "-c", getPcsEtcdOOMDefault)
o.Expect(err).To(o.BeNil(), fmt.Sprintf("expected pcs resource describe to succeed on Node %s: error %v", firstNode.Name, err))
o.Expect(pcsOutput).To(o.ContainSubstring("Default: -997"),
fmt.Sprintf("expected pcs resource describe to show OOM default of -997 on Node %s, got: %s", firstNode.Name, pcsOutput))

g.By("Ensuring etcd process OOM score adjustment is -997 on each node")
for _, node := range nodes.Items {
got, err := exutil.DebugNodeRetryWithOptionsAndChroot(oc, node.Name, "openshift-etcd", "bash", "-c", getEtcdOOMScoreAdj)
o.Expect(err).To(o.BeNil(), fmt.Sprintf("expected to read oom_score_adj without errors on Node %s: error %v", node.Name, err))
o.Expect(strings.TrimSpace(got)).To(o.Equal(expectedOOMScoreAdj),
fmt.Sprintf("expected etcd oom_score_adj to be %s on Node %s, got: %s", expectedOOMScoreAdj, node.Name, got))
}
})
})