[WIP] CNTRLPLANE-3052: remove unnecessary exceptions from monitoring test#30924
[WIP] CNTRLPLANE-3052: remove unnecessary exceptions from monitoring test#30924ehearne-redhat wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@ehearne-redhat: This pull request references CNTRLPLANE-3052 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughSimplified the exceptions list in the default-service-account monitor test by removing Jira-tracked pod/namespace exceptions and namespace-specific handlers for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.3)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ehearne-redhat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| return "", false | ||
| }, | ||
| // Handle the outlier manually | ||
| // This one checks if it is a debug pod or not. |
There was a problem hiding this comment.
I'm thinking we should probably add a comment here to explain why we are keeping it e.g. // debug pod does not run by default on an OpenShift cluster .
| @@ -43,52 +43,8 @@ func exceptionWithJira(prefix, jiraURL string) func(corev1.Pod) (string, bool) { | |||
| // OpenShift components should not be using the default service account. | |||
| // Therefore, no new components should be added to this list. | |||
There was a problem hiding this comment.
We could also add a comment here e.g. // The following are current exceptions due to not being part of the core OpenShift payload, or we are waiting on components to reach GA.
ehearne-redhat
force-pushed
the
ocpstrat-2401-remove-unnecessary-exceptions
branch
from
5e35609 to
2443300
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
1 similar comment
✅ Actions performedReview triggered.
|
|
Scheduling required tests: |
|
Note that the errors in the tests are due to the open PR's for those components. :) |
|
@ehearne-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Tests are failing as we are waiting on the following PR's to be reviewed/merged: |
2 participants
This PR removes unnecessary exceptions from the default service account monitoring test. Now that OCPSTRAT-2401 is nearing completion, we need to look at removing these exceptions since they are now complete.
Note some of the items still have PRs. When they are merged I will move this out of WIP status.